Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2718363003: Add source information to the covariance checks inserted for strong mode (Closed)

Created:
3 years, 9 months ago by asgerf
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add source information to the covariance checks inserted for strong mode BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/af10678cb3113a4b62cf8209da89ecacf878973c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/kernel/lib/transformations/insert_covariance_checks.dart View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
3 years, 9 months ago (2017-02-28 16:21:08 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 9 months ago (2017-03-01 08:44:18 UTC) #3
Dmitry Stefantsov
LGTM
3 years, 9 months ago (2017-03-01 08:44:19 UTC) #4
asgerf
3 years, 9 months ago (2017-03-01 08:51:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af10678cb3113a4b62cf8209da89ecacf878973c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698