chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc - Issue 2718333002: Move ash_util functions from 'chrome' namespace to 'ash_util' namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

Issue 2718333002: Move ash_util functions from 'chrome' namespace to 'ash_util' namespace (Closed)

Patch Set: Rebase after https://codereview.chromium.org/2721883002 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

diff --git a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

index a291ad186993bed52c50f46eafd41783da8533b3..737f68eebb9403a7cb4a07cd7a8af8ba7f4365c5 100644

--- a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

+++ b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

@@ -50,7 +50,7 @@ void CandidateWindowControllerImpl::InitCandidateWindowView() {

// as we have in ChromeOS. For example, candidate pop-up disappears when

// dragging the window in mash, but it shouldn't.

gfx::NativeView parent = nullptr;

- if (!chrome::IsRunningInMash()) {

+ if (!ash_util::IsRunningInMash()) {

aura::Window* active_window = ash::wm::GetActiveWindow();

parent = ash::Shell::GetContainer(

active_window ? active_window->GetRootWindow()