Move ash_util functions from 'chrome' namespace to 'ash_util' namespace

chrome/browser/ui/ash/ash_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_ASH_UTIL_H_
 #define CHROME_BROWSER_UI_ASH_ASH_UTIL_H_
 
 #include <memory>
 
 #include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 
 namespace service_manager {
 class Service;
 }
 
 namespace ui {
 class Accelerator;
 }  // namespace ui
 
 namespace ash_util {

[sky, 2017/02/28 17:40:26]

Generally we don't use namespaces like this in chrome code. See long threads on
chromium-dev for details. tl;dr here is no namespace.

[James Cook, 2017/02/28 17:47:25]

I think we use namespaces like this where there is a group of related utility
functions, in order to avoid a class with only static members:

https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...

"Sometimes it is useful to define a function not bound to a class instance. Such
a function can be either a static member or a nonmember function. Nonmember
functions should not depend on external variables, and should nearly always
exist in a namespace. Rather than creating classes only to group static member
functions which do not share static data, use namespaces instead. For a header
myproject/foo_bar.h, for example, write

namespace myproject {
namespace foo_bar {
void Function1();
void Function2();
}  // namespace foo_bar
}  // namespace myproject"

I thought the "don't use namespaces in chrome" guidance was to not use
"chrome::" inside src/chrome.

 
 // Creates an in-process Service instance of which can host common ash
 // interfaces.
 std::unique_ptr<service_manager::Service> CreateEmbeddedAshService(
     const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
 
-}  // namespace ash_util
-
-// TODO(jamescook): Change this namespace to ash_util.
-namespace chrome {
-
 // Returns true if Ash should be run at startup.
 bool ShouldOpenAshOnStartup();
 
 // Returns true if Chrome is running in the mash shell.
 bool IsRunningInMash();
 
 // Returns true if the given |accelerator| has been deprecated and hence can
 // be consumed by web contents if needed.
 bool IsAcceleratorDeprecated(const ui::Accelerator& accelerator);
 
-}  // namespace chrome
+}  // namespace ash_util
 
 #endif  // CHROME_BROWSER_UI_ASH_ASH_UTIL_H_