Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 27183013: Use [ImplementedAs=domWindow] for Document.defaultView() (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, chromiumbugtracker_adobe.com
Visibility:
Public.

Description

Use [ImplementedAs=domWindow] for Document.defaultView() Use [ImplementedAs=domWindow] for Document.defaultView() to avoid having 2 implementation methods that return the same thing. This makes our implementation more consistent. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M Source/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/NamedFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
7 years, 2 months ago (2013-10-14 21:41:23 UTC) #1
Inactive
+abarth for Source/web
7 years, 2 months ago (2013-10-14 21:42:50 UTC) #2
arv (Not doing code reviews)
I would prefer that we got rid of domWindow instead.
7 years, 2 months ago (2013-10-14 21:49:47 UTC) #3
Inactive
On 2013/10/14 21:49:47, arv wrote: > I would prefer that we got rid of domWindow ...
7 years, 2 months ago (2013-10-14 22:35:04 UTC) #4
haraken
On 2013/10/14 22:35:04, Chris Dumez wrote: > On 2013/10/14 21:49:47, arv wrote: > > I ...
7 years, 2 months ago (2013-10-15 00:18:52 UTC) #5
arv (Not doing code reviews)
I always tend to prefer sticking to the names in the spec for least confusion ...
7 years, 2 months ago (2013-10-15 00:48:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27183013/1
7 years, 2 months ago (2013-10-15 13:16:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=8885
7 years, 2 months ago (2013-10-15 13:29:55 UTC) #8
Inactive
On 2013/10/15 13:29:55, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-15 15:37:19 UTC) #9
abarth-chromium
Source/web <--- LGTM
7 years, 2 months ago (2013-10-15 18:29:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27183013/1
7 years, 2 months ago (2013-10-15 18:30:05 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 03:59:49 UTC) #12
Message was sent while issue was closed.
Change committed as 159715

Powered by Google App Engine
This is Rietveld 408576698