Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27183005: Use DEFINE_CSS_VALUE_TYPE_CASTS() for SVGColor, SVGPaint, and TextCloneCSSValue (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, dglazkov+blink, f(malita), darktears, pdr, apavlov+blink_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use DEFINE_CSS_VALUE_TYPE_CASTS() for SVGColor, SVGPaint, and TextCloneCSSValue SVGColor, SVGPaint and TextCloneCSSValue don't use DEFINE_CSS_VALUE_TYPE_CASTS() yet. It will help to detect bad type casts. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160045

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -32 lines) Patch
M Source/core/css/CSSValue.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M Source/core/svg/SVGColor.h View 1 2 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/svg/SVGPaint.h View 1 2 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-14 15:54:12 UTC) #1
esprehn
https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp File Source/core/css/CSSValue.cpp (right): https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp#newcode89 Source/core/css/CSSValue.cpp:89: void toTextCloneCSSValue(const TextCloneCSSValue*); We should just fix the macros. ...
7 years, 2 months ago (2013-10-15 01:17:41 UTC) #2
gyuyoung-inactive
https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp File Source/core/css/CSSValue.cpp (right): https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp#newcode89 Source/core/css/CSSValue.cpp:89: void toTextCloneCSSValue(const TextCloneCSSValue*); On 2013/10/15 01:17:41, esprehn wrote: > ...
7 years, 2 months ago (2013-10-15 01:46:27 UTC) #3
gyuyoung-inactive
https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp File Source/core/css/CSSValue.cpp (right): https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp#newcode89 Source/core/css/CSSValue.cpp:89: void toTextCloneCSSValue(const TextCloneCSSValue*); On 2013/10/15 01:46:27, gyuyoung wrote: > ...
7 years, 2 months ago (2013-10-15 03:36:47 UTC) #4
gyuyoung-inactive
On 2013/10/15 03:36:47, gyuyoung wrote: > https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp > File Source/core/css/CSSValue.cpp (right): > > https://chromiumcodereview.appspot.com/27183005/diff/1/Source/core/css/CSSValue.cpp#newcode89 > ...
7 years, 2 months ago (2013-10-21 01:55:00 UTC) #5
tkent
lgtm
7 years, 2 months ago (2013-10-21 01:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27183005/10001
7 years, 2 months ago (2013-10-21 01:58:09 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 03:32:00 UTC) #8
Message was sent while issue was closed. 
Change committed as 160045

Powered by Google App Engine
This is Rietveld 408576698