Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2718293002: Selection API: Add a UseCounter for focus change by selection change. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: Add a UseCounter for focus change by selection change. BUG=690272 Review-Url: https://codereview.chromium.org/2718293002 Cr-Commit-Position: refs/heads/master@{#453548} Committed: https://chromium.googlesource.com/chromium/src/+/beb1e82fe0893056ca1ffb9c729dc8f52cf2f30b

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix crashes in some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 9 months ago (2017-02-28 04:19:20 UTC) #4
yosin_UTC9
lgtm
3 years, 9 months ago (2017-02-28 06:59:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718293002/1
3 years, 9 months ago (2017-02-28 06:59:44 UTC) #9
tkent
https://codereview.chromium.org/2718293002/diff/1/third_party/WebKit/Source/core/editing/DOMSelection.cpp File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right): https://codereview.chromium.org/2718293002/diff/1/third_party/WebKit/Source/core/editing/DOMSelection.cpp#newcode89 third_party/WebKit/Source/core/editing/DOMSelection.cpp:89: if (focusedElement != frame()->document()->focusedElement()) This line crashed because frame() ...
3 years, 9 months ago (2017-02-28 07:14:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718293002/20001
3 years, 9 months ago (2017-02-28 08:57:19 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 09:03:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/beb1e82fe0893056ca1ffb9c729d...

Powered by Google App Engine
This is Rietveld 408576698