Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: ios/chrome/browser/tabs/tab.h

Issue 2718273003: Change return type of Tab -navigationManager. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | ios/chrome/browser/tabs/tab.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_ 5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_
6 #define IOS_CHROME_BROWSER_TABS_TAB_H_ 6 #define IOS_CHROME_BROWSER_TABS_TAB_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 class ChromeBrowserState; 50 class ChromeBrowserState;
51 } 51 }
52 52
53 namespace sessions { 53 namespace sessions {
54 class SerializedNavigationEntry; 54 class SerializedNavigationEntry;
55 struct SessionTab; 55 struct SessionTab;
56 } 56 }
57 57
58 namespace web { 58 namespace web {
59 class NavigationItem; 59 class NavigationItem;
60 class NavigationManager;
60 class NavigationManagerImpl; 61 class NavigationManagerImpl;
61 struct Referrer; 62 struct Referrer;
62 class WebState; 63 class WebState;
63 } 64 }
64 65
65 // Notification sent by a Tab when it starts to load a new URL. This 66 // Notification sent by a Tab when it starts to load a new URL. This
66 // notification must only be used for crash reporting as it is also sent for 67 // notification must only be used for crash reporting as it is also sent for
67 // pre-rendered tabs. 68 // pre-rendered tabs.
68 extern NSString* const kTabUrlStartedLoadingNotificationForCrashReporting; 69 extern NSString* const kTabUrlStartedLoadingNotificationForCrashReporting;
69 70
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 238
238 // Dismisses all modals owned by the tab. 239 // Dismisses all modals owned by the tab.
239 - (void)dismissModals; 240 - (void)dismissModals;
240 241
241 // Opens StoreKit modal to download a native application identified with 242 // Opens StoreKit modal to download a native application identified with
242 // |appId|. 243 // |appId|.
243 - (void)openAppStore:(NSString*)appId; 244 - (void)openAppStore:(NSString*)appId;
244 245
245 // Returns the NavigationManager for this tab's WebState. Requires WebState to 246 // Returns the NavigationManager for this tab's WebState. Requires WebState to
246 // be populated. Can return null. 247 // be populated. Can return null.
247 - (web::NavigationManagerImpl*)navigationManager; 248 // TODO(crbug.com/620465): remove navigationManagerImpl once Tab no longer uses
249 // nor exposes private ios/web/ API.
250 - (web::NavigationManager*)navigationManager;
251 - (web::NavigationManagerImpl*)navigationManagerImpl;
248 252
249 // Update the tab's history by replacing all previous navigations with 253 // Update the tab's history by replacing all previous navigations with
250 // |navigations|. 254 // |navigations|.
251 - (void)replaceHistoryWithNavigations: 255 - (void)replaceHistoryWithNavigations:
252 (const std::vector<sessions::SerializedNavigationEntry>&)navigations 256 (const std::vector<sessions::SerializedNavigationEntry>&)navigations
253 currentIndex:(NSInteger)currentIndex; 257 currentIndex:(NSInteger)currentIndex;
254 258
255 // Navigate forwards or backwards to |item|. 259 // Navigate forwards or backwards to |item|.
256 - (void)goToItem:(const web::NavigationItem*)item; 260 - (void)goToItem:(const web::NavigationItem*)item;
257 - (void)reload; 261 - (void)reload;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 346
343 // Called when this tab is hidden. 347 // Called when this tab is hidden.
344 - (void)wasHidden; 348 - (void)wasHidden;
345 349
346 // Evaluates U2F result. 350 // Evaluates U2F result.
347 - (void)evaluateU2FResultFromURL:(const GURL&)url; 351 - (void)evaluateU2FResultFromURL:(const GURL&)url;
348 352
349 @end 353 @end
350 354
351 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_ 355 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | ios/chrome/browser/tabs/tab.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698