third_party/WebKit/Source/core/css/CSSImageValue.cpp - Issue 2718273002: Resolve background image's url if absolute url is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 2718273002: Resolve background image's url if absolute url is empty (Closed)

Patch Set: Resolve background image url before use Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

index 74b63bc1ad9ccc5080eca784cf6f9f77d682e66b..24aed39f22c80831b316c7c7491facc5950e197c 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

@@ -53,6 +53,8 @@ CSSImageValue::~CSSImageValue() {}

StyleImage* CSSImageValue::cacheImage(const Document& document,

CrossOriginAttributeValue crossOrigin) {

if (!m_cachedImage) {

+ if (m_absoluteURL.isEmpty())

+ reResolveURL(document);

FetchRequest request(ResourceRequest(m_absoluteURL),

m_initiatorName.isEmpty()

? FetchInitiatorTypeNames::css