third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html - Issue 2718273002: Resolve background image's url if absolute url is empty

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html

Issue 2718273002: Resolve background image's url if absolute url is empty (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	rune 2017/02/28 09:29:05 Drop html and head tags. Drop html and head tags.
	4 <script>

	5 function makeIframe() {

	6 var iframe = document.getElementById('iframe');

	7 iframe.contentDocument.body.innerHTML = `

	8 <style>

	9 .bg-img {

	10 background: url('./resources/green-24x24.png') no-repeat #3D6AA2;
	rune 2017/02/28 09:29:05 Looks like no-repeat or repeat should be enough. Looks like no-repeat or repeat should be enough.
	11 width: 24px;

	12 height:24px;

	13 }

	14 </style>

	15 <div class='bg-img'></div>`;

	16 }

	17 </script>

	18 </head>

	19 <body onload="makeIframe()">
	rune 2017/02/28 09:29:06 Do you really need to wait for onload? Can't you s Do you really need to wait for onload? Can't you simply do: <!DOCTYPE html> <iframe id="iframe"></iframe> <script> iframe.contentDocument.body.innerHTML ... ... </script>
	20 <iframe id="iframe"></iframe>

	21 </body>

	22 </html>

OLD	NEW