MD Settings: checkbox: Support inverted when setting pref

chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A behavior to help controls that handle a boolean preference, such as
  * checkbox and toggle button.
  */
 
@@ skipping 72 matching lines @@
   /** Reset the checked state to match the current pref value. */
   resetToPrefValue: function() {
     this.checked = this.getNewValue_(this.pref.value);
   },
 
   /** Update the pref to the current |checked| value. */
   sendPrefChange: function() {
     // Ensure that newValue is the correct type for the pref type, either
     // a boolean or a number.
     if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER) {
+      assert(!this.inverted);
       this.set('pref.value', this.checked ? 1 : this.numericUncheckedValue);
       return;
     }
-    this.set('pref.value', this.checked);
+    this.set('pref.value', this.inverted ? !this.checked : this.checked);
   },
 
   /**
    * Polymer observer for pref.value.
    * @param {*} prefValue
    * @private
    */
   prefValueChanged_: function(prefValue) {
     this.checked = this.getNewValue_(prefValue);
   },
 
   /**
    * @param {*} value
    * @return {boolean} The value as a boolean, inverted if |inverted| is true.
    * @private
    */
   getNewValue_: function(value) {
     // For numeric prefs, the control is only false if the value is exactly
     // equal to the unchecked-equivalent value.
-    if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER)
-      value = value != this.numericUncheckedValue;
-
+    if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER) {
+      assert(!this.inverted);
+      return value != this.numericUncheckedValue;
+    }
     return this.inverted ? !value : !!value;
   },
 
   /**
    * @return {boolean} Whether the checkbox should be disabled.
    * @private
    */
   controlDisabled_: function() {
     return this.disabled || this.isPrefPolicyControlled();
   },
 };
 
 /** @polymerBehavior */
 var SettingsBooleanControlBehavior = [
   CrPolicyPrefBehavior,
   PrefControlBehavior,
   SettingsBooleanControlBehaviorImpl,
 ];