Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2718253003: Flush deferred action queue (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flush deferred action queue It is possible for deferred actions to be queued without enqueing classes. This can happen when resolving a typedef for mirrors - a cyclic check action may be added as the only change. TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/8eedb9c6527f955413e47c9350d3c5114cd89942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
onEmptyQueue calls the mirrors code which resolves an otherwise unreferenced typedef which adds a deferred ...
3 years, 9 months ago (2017-02-28 03:12:36 UTC) #1
sra1
Committed patchset #1 (id:1) manually as 8eedb9c6527f955413e47c9350d3c5114cd89942 (presubmit successful).
3 years, 9 months ago (2017-02-28 03:13:06 UTC) #3
Johnni Winther
3 years, 9 months ago (2017-02-28 09:36:47 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698