Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6591)

Unified Diff: chrome/browser/resources/login/display_manager.js

Issue 271823005: Revert of Add error messsage bubble flag for tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/login/display_manager.js
diff --git a/chrome/browser/resources/login/display_manager.js b/chrome/browser/resources/login/display_manager.js
index d6112674ce1f56e8521d6d8d5283b08d56bdbcf8..3644beb1321bd8ec27b9ef14fdf8739d24852fb2 100644
--- a/chrome/browser/resources/login/display_manager.js
+++ b/chrome/browser/resources/login/display_manager.js
@@ -177,11 +177,6 @@
* @type {string}
*/
displayType_: DISPLAY_TYPE.UNKNOWN,
-
- /**
- * Error message (bubble) was shown. This is checked in tests.
- */
- errorMessageWasShownForTesting_: false,
get displayType() {
return this.displayType_;
@@ -881,10 +876,8 @@
}
var currentScreen = Oobe.getInstance().currentScreen;
- if (currentScreen && typeof currentScreen.showErrorBubble === 'function') {
+ if (currentScreen && typeof currentScreen.showErrorBubble === 'function')
currentScreen.showErrorBubble(loginAttempts, error);
- this.errorMessageWasShownForTesting_ = true;
- }
};
/**
@@ -914,7 +907,6 @@
*/
DisplayManager.clearErrors = function() {
$('bubble').hide();
- this.errorMessageWasShownForTesting_ = false;
};
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698