Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 271823005: Revert of Add error messsage bubble flag for tests. (Closed)

Created:
6 years, 7 months ago by Alexander Alekseev
Modified:
6 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add error messsage bubble flag for tests. (https://codereview.chromium.org/268373002/) Reason for revert: Win tests are failing. Reverting to check if this CL is to blame. Original issue's description: > Add error messsage bubble flag for tests. > > Tests checking for eroro message buble can be flaky, because on-screen message > can disappear before test checks for it. This CL adds special flag for tests. > > BUG=339348 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268924 TBR=antrim@chromium.org,achuith@chromium.org NOTREECHECKS=true NOTRY=true BUG=339348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/resources/login/display_manager.js View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Alekseev
Created Revert of Add error messsage bubble flag for tests.
6 years, 7 months ago (2014-05-08 17:47:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/271823005/1
6 years, 7 months ago (2014-05-08 17:52:12 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 17:59:08 UTC) #3
Message was sent while issue was closed.
Change committed as 269072

Powered by Google App Engine
This is Rietveld 408576698