Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 27182002: Introduce ParserBase for common code between parser and pre-parser. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Introduce ParserBase for common code between parser and pre-parser. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -276 lines) Patch
M src/parser.h View 4 chunks +1 line, -55 lines 0 comments Download
M src/parser.cc View 10 chunks +9 lines, -39 lines 0 comments Download
M src/preparser.h View 7 chunks +112 lines, -80 lines 0 comments Download
M src/preparser.cc View 37 chunks +77 lines, -102 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 2 months ago (2013-10-14 13:24:11 UTC) #1
ulan
LGTM
7 years, 2 months ago (2013-10-14 15:26:37 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-10-14 16:47:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698