Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3853)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_buttons.js

Issue 2718133004: ChromeOS OOBE: More accessibility fixes. (Closed)
Patch Set: Update after review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_buttons.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_buttons.js b/chrome/browser/resources/chromeos/login/oobe_buttons.js
index 53cf9f53fee089a988bb7a79220591393ee8addb..1fc41bbb7d8ce4741b5bae6caa73b53399fdfcda 100644
--- a/chrome/browser/resources/chromeos/login/oobe_buttons.js
+++ b/chrome/browser/resources/chromeos/login/oobe_buttons.js
@@ -10,7 +10,11 @@ Polymer({
inverse: Boolean,
- ariaLabel: String,
+ /* Note that we are not using "aria-label" property here, because
+ * we want to pass the label value but not actually declare it as an
+ * ARIA property anywhere but the actual target element.
+ */
+ labelForAria: String,
},
focus: function() {
@@ -29,7 +33,11 @@ Polymer({
properties: {
disabled: {type: Boolean, value: false, reflectToAttribute: true},
- ariaLabel: String,
+ /* Note that we are not using "aria-label" property here, because
+ * we want to pass the label value but not actually declare it as an
+ * ARIA property anywhere but the actual target element.
+ */
+ labelForAria: String,
},
focus: function() {
@@ -65,7 +73,11 @@ Polymer({
properties: {
icon: String,
- ariaLabel: String
+ /* Note that we are not using "aria-label" property here, because
+ * we want to pass the label value but not actually declare it as an
+ * ARIA property anywhere but the actual target element.
+ */
+ labelForAria: String
},
focus: function() {
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_buttons.html ('k') | chrome/browser/resources/chromeos/login/oobe_eula.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698