ChromeOS OOBE: More accessibility fixes.

chrome/browser/resources/chromeos/login/oobe_welcome.html

 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_icon.html">
 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_select.html">
 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-iconset-svg.html">
@@ skipping 40 matching lines @@
     </defs>
   </svg>
 </iron-iconset-svg>
 
 <dom-module name="oobe-welcome-md">
   <template>
     <link rel="stylesheet" href="oobe_dialog_host.css">
     <link rel="stylesheet" href="oobe_welcome.css">
     <link rel="stylesheet" href="oobe_dialog_parameters.css">
     <oobe-welcome-dialog id="welcomeScreen" role="dialog"
-        aria-label="[[formatMessage_('networkScreenGreeting')]]"
+        aria-label$="[[formatMessage_('networkScreenGreeting')]]"
         current-language="[[currentLanguage]]"
         on-language-button-clicked="onWelcomeSelectLanguageButtonClicked_"
         on-accessibility-button-clicked="onWelcomeAccessibilityButtonClicked_"
         on-timezone-button-clicked="onWelcomeTimezoneButtonClicked_"
         on-next-button-clicked="onWelcomeNextButtonClicked_"
         timezone-button-visible="[[isTimezoneButtonVisible_(highlightStrength)]]"
         debugging-link-visible="[[debuggingLinkVisible]]"
         >
     </oobe-welcome-dialog>
     <oobe-dialog id="languageScreen" role="dialog" hidden has-buttons
-        aria-label="[[formatMessage_('languageSectionTitle')]]">
+        aria-label$="[[formatMessage_('languageSectionTitle')]]">
       <iron-icon icon="icons:language" class="oobe-icon"></iron-icon>
       <div class="header">
         <h1 class="title" i18n-content="languageSectionTitle"></h1>
       </div>
       <div class="footer layout vertical">
         <template is="dom-if" if="[[enabled]]">
           <div id="languageDropdownContainer"
               class="flex layout horizontal justified language-selection-entry">
             <div class="language-selection-title layout vertical center-justified"
                 i18n-content="languageDropdownTitle">
             </div>
             <oobe-i18n-dropdown id="languageSelect" items="[[languages]]"
                 on-select-item="onLanguageSelected_"
-                class="focus-on-show">
+                class="focus-on-show"
+                label-for-aria="[[formatMessage_('languageDropdownLabel')]]">

[michaelpg, 2017/02/28 10:38:17]

no parameter means no need for formatMessage_, just use i18n-values?

if you can do that in this entire file, we can remove formatMessage_ from
oobe_welcome.js

[Alexander Alekseev, 2017/03/01 00:48:34]

I don't know how to use i18n-values for polymer attributes. ($i18n{} would not
work.) Could you suggest a sample code?

[michaelpg, 2017/03/01 20:26:49]

It is explained in i18n_template_no_process.js and used in several places in
OOBE as examples. I don't think Polymer makes it any different, so:
    i18n-values="label-for-aria:languageDropdownLabel"

If $i18n{} would work, it would look like:
    label-for-aria="$i18n{languageDropdownLabel}"

Either way, you are setting the attribute directly, not binding it to another
Polymer property.

[Alexander Alekseev, 2017/03/01 21:49:09]

Done.

             </oobe-i18n-dropdown>
           </div>
           <div id="keyboardDropdownContainer"
               class="flex layout horizontal justified language-selection-entry">
             <div class="language-selection-title layout vertical center-justified"
                 i18n-content="keyboardDropdownTitle">
             </div>
             <oobe-i18n-dropdown id="keyboardSelect" items="[[keyboards]]"
-                on-select-item="onKeyboardSelected_">
+                on-select-item="onKeyboardSelected_"
+                label-for-aria="[[formatMessage_('keyboardDropdownLabel')]]">
             </oobe-i18n-dropdown>
           </div>
         </template>
       </div>
       <div class="bottom-buttons layout horizontal end-justified">
         <oobe-text-button inverse on-tap="closeLanguageSection_">
           <div i18n-content="oobeOKButtonText"></div>
         </oobe-text-button>
       </div>
     </oobe-dialog>
     <oobe-dialog id="accessibilityScreen" role="dialog" hidden has-buttons
-        aria-label="[[formatMessage_('accessibilitySectionTitle')]]">
+        aria-label$="[[formatMessage_('accessibilitySectionTitle')]]">
       <iron-icon icon="icons:accessibility" class="oobe-icon"></iron-icon>
       <div class="header">
         <h1 class="title" i18n-content="accessibilitySectionTitle"></h1>
         <div class="subtitle" i18n-content="accessibilitySectionHint"></div>
       </div>
       <div class="footer layout vertical">
         <oobe-a11y-option checked="[[a11yStatus.spokenFeedbackEnabled]]"
             on-change="onA11yOptionChanged_"
             chrome-message="enableSpokenFeedback"
             label-for-aria="[[formatMessage_('spokenFeedbackOption')]]"
@@ skipping 45 matching lines @@
           </span>
         </oobe-a11y-option>
       </div>
       <div class="bottom-buttons layout horizontal end-justified">
         <oobe-text-button inverse on-tap="closeAccessibilitySection_">
           <div i18n-content="oobeOKButtonText"></div>
         </oobe-text-button>
       </div>
     </oobe-dialog>
     <oobe-dialog id="timezoneScreen" role="dialog" hidden has-buttons
-        aria-label="[[formatMessage_('timezoneSectionTitle')]]">
+        aria-label$="[[formatMessage_('timezoneSectionTitle')]]">
       <iron-icon icon="oobe-welcome-64:timezone" class="oobe-icon"></iron-icon>
       <div class="header">
         <h1 class="title" i18n-content="timezoneSectionTitle"></h1>
       </div>
       <div class="footer layout vertical">
         <div class="flex layout horizontal justified timezone-selection-entry">
           <div class="timezone-selection-title layout vertical center-justified"
               i18n-content="timezoneDropdownTitle">
           </div>
           <oobe-i18n-dropdown id="timezoneSelect" items="[[timezones]]"
               on-select-item="onTimezoneSelected_"
               label-for-aria="[[formatMessage_('timezoneDropdownTitle')]]"
               class="focus-on-show">
           </oobe-i18n-dropdown>
         </div>
       </div>
       <div class="bottom-buttons layout horizontal end-justified">
         <oobe-text-button inverse on-tap="closeTimezoneSection_">
           <div i18n-content="oobeOKButtonText"></div>
         </oobe-text-button>
       </div>
     </oobe-dialog>
     <oobe-dialog id="networkSelectionScreen" role="dialog" hidden has-buttons
-        aria-label="[[formatMessage_('networkSectionTitle')]]"
+        aria-label$="[[formatMessage_('networkSectionTitle')]]"
         on-show-dialog="onNetworkSelectionScreenShown_">
       <iron-icon icon="oobe-welcome:wifi" class="oobe-icon"></iron-icon>
       <div class="header">
         <h1 class="title" i18n-content="networkSectionTitle"></h1>
         <div class="subtitle" i18n-content="networkSectionHint"></div>
       </div>
       <div class="footer layout vertical">
         <cr-network-select id="networkSelect"
             on-default-network-changed="onDefaultNetworkChanged_"
             on-network-item-selected="onNetworkListNetworkItemSelected_"
             on-custom-item-selected="onNetworkListCustomItemSelected_"
             custom-items="[[getNetworkCustomItems_()]]"
             no-bottom-scroll-border
             class="focus-on-show">
         </cr-network-select>
       </div>
       <div class="bottom-buttons layout horizontal justified">
         <oobe-back-button on-tap="onNetworkSelectionBackButtonPressed_">
         </oobe-back-button>
         <oobe-next-button disabled="[[!isConnected_]]"
             on-tap="onSelectedNetworkConnected_">
         </oobe-next-button>
       </div>
     </oobe-dialog>
   </template>
 </dom-module>