Rewrite extensions console to not leak function templates.

extensions/renderer/console.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_CONSOLE_H_
 #define EXTENSIONS_RENDERER_CONSOLE_H_
 
 #include <string>
 
 #include "content/public/common/console_message_level.h"
 #include "v8/include/v8.h"
 
 namespace content {
 class RenderFrame;
 }
 
 namespace extensions {
 
 // Utility for logging messages to RenderFrames.
 namespace console {
 
 // Adds |message| to the console of |render_frame|. If |render_frame| is null,
 // LOG()s the message instead.
-void Debug(content::RenderFrame* render_frame, const std::string& message);
-void Log(content::RenderFrame* render_frame, const std::string& message);
-void Warn(content::RenderFrame* render_frame, const std::string& message);
-void Error(content::RenderFrame* render_frame, const std::string& message);
+void AddMessage(content::RenderFrame* render_frame,
+                content::ConsoleMessageLevel level,
+                const std::string& message);
+inline void Debug(content::RenderFrame* render_frame,

[Devlin, 2017/02/27 22:32:12]

Given we now bind these to the same function and just use v8::Data to determine
the level, I'd say we can remove the Debug(), Log(), Warn(), Error()
implementations.  Two don't seem to be used and the other two are only used once
or twice - I think callers can just use AddMessage() and pass in the level.

If you don't want to handle that in this CL, though, that's fine (it is  a
little orthogonal).

[jbroman, 2017/02/27 22:52:49]

I'd made it compile-time-inlinable, and I did notice how few call sites there
were. I've now inlined them at the source level. :D

+                  const std::string& message) {
+  AddMessage(render_frame, content::CONSOLE_MESSAGE_LEVEL_VERBOSE, message);
+}
+inline void Log(content::RenderFrame* render_frame,
+                const std::string& message) {
+  AddMessage(render_frame, content::CONSOLE_MESSAGE_LEVEL_INFO, message);
+}
+inline void Warn(content::RenderFrame* render_frame,
+                 const std::string& message) {
+  AddMessage(render_frame, content::CONSOLE_MESSAGE_LEVEL_WARNING, message);
+}
+inline void Error(content::RenderFrame* render_frame,
+                  const std::string& message) {
+  AddMessage(render_frame, content::CONSOLE_MESSAGE_LEVEL_ERROR, message);
+}
 
 // Logs an Error then crashes the current process.
 void Fatal(content::RenderFrame* render_frame, const std::string& message);
 
-void AddMessage(content::RenderFrame* render_frame,
-                content::ConsoleMessageLevel level,
-                const std::string& message);
-
 // Returns a new v8::Object with each standard log method (Debug/Log/Warn/Error)
 // bound to respective debug/log/warn/error methods. This is a direct drop-in
 // replacement for the standard devtools console.* methods usually accessible
 // from JS.
 v8::Local<v8::Object> AsV8Object(v8::Isolate* isolate);
 
 }  // namespace console
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_CONSOLE_H_