mash: Store chrome --mash crash key metadata in shared memory

chrome/app/mash/mash_runner.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/mash/mash_runner.h"
 
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/base_paths.h"
@@ skipping 38 matching lines @@
 #include "services/service_manager/public/cpp/standalone_service/standalone_service.h"
 #include "services/service_manager/public/interfaces/service_factory.mojom.h"
 #include "services/service_manager/runner/common/client_util.h"
 #include "services/service_manager/runner/common/switches.h"
 #include "services/service_manager/runner/init.h"
 #include "services/ui/public/interfaces/constants.mojom.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 #include "ui/base/ui_base_switches.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/app/mash/mash_crash_keys.h"
+#endif  // defined(OS_CHROMEOS)
+
 using service_manager::mojom::ServiceFactory;
 
 namespace {
 
 // kProcessType used to identify child processes.
 const char* kMashChild = "mash-child";
 
 const char kChromeMashServiceName[] = "chrome_mash";
 
 bool IsChild() {
@@ skipping 69 matching lines @@
   }
 
   LOG(ERROR) << "Main process exiting because service " << identity.name()
              << " quit unexpectedly.";
   *exit_value = 1;
   run_loop->Quit();
 }
 
 }  // namespace
 
-MashRunner::MashRunner() {}
+MashRunner::MashRunner() {
+#if defined(OS_CHROMEOS)
+  // NOTE: On Chrome OS, crash reporting for the root process and non-browser
+  // service processes is handled by the OS-level crash_reporter, not in-process
+  // breakpad. It therefore uses its own crash key implementation.
+  mash_crash_keys::Initialize();

[hashimoto, 2017/03/02 07:42:23]

How about putting this code in MashMain or RunMain to be consistent with other
initialization code?

+#endif
+}
 
-MashRunner::~MashRunner() {}
+MashRunner::~MashRunner() {

[hashimoto, 2017/03/02 07:42:23]

ditto.
Other shutdown code is in RunMain().

+#if defined(OS_CHROMEOS)
+  mash_crash_keys::Shutdown();
+#endif
+}
 
 int MashRunner::Run() {
   base::TaskScheduler::CreateAndSetSimpleTaskScheduler(
       base::SysInfo::NumberOfProcessors());
 
   if (IsChild())
     return RunChild();
 
   return RunMain();
 }
@@ skipping 89 matching lines @@
   // TODO(sky): wire this up correctly.
   service_manager::InitializeLogging();
 
 #if defined(OS_LINUX)
   base::AtExitManager exit_manager;
 #endif
 
 #if !defined(OFFICIAL_BUILD)
   // Initialize stack dumping before initializing sandbox to make sure symbol
   // names in all loaded libraries will be cached.
-  // NOTE: On Chrome OS, crash reporting for the root process and non-browser
-  // service processes is handled by the OS-level crash_reporter.

[hashimoto, 2017/03/02 07:42:23]

IMO we still need this comment here to describe how stack dumping works on
Chrome OS.

   base::debug::EnableInProcessStackDumping();
 #endif
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kTraceToConsole)) {
     base::trace_event::TraceConfig trace_config =
         tracing::GetConfigForTraceToConsole();
     base::trace_event::TraceLog::GetInstance()->SetEnabled(
         trace_config,
         base::trace_event::TraceLog::RECORDING_MODE);
@@ skipping 15 matching lines @@
       command_line->GetSwitchValueASCII(switches::kWaitForDebugger)) {
     return;
   }
 
   // Include the pid as logging may not have been initialized yet (the pid
   // printed out by logging is wrong).
   LOG(WARNING) << "waiting for debugger to attach for service " << service_name
                << " pid=" << base::Process::Current().Pid();
   base::debug::WaitForDebugger(120, true);
 }