Fix nits from earlier CLs

chrome/test/data/webui/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "base/feature_list.h"');
 GEN('#include "chrome/common/chrome_features.h"');
 
 /**
  * Test fixture for print preview WebUI testing.
  * @constructor
@@ skipping 357 matching lines @@
               height_microns: 279400,
               is_default: true
             }
           ]
         }
       }
     }
   };
 }
 
+function isPrintAsImageEnabled() {
+  return !cr.isWindows && !cr.isMac;
+}
+
 // Test restore settings with one destination.
 TEST_F('PrintPreviewWebUITest', 'TestPrintPreviewRestoreLocalDestination',
     function() {
   this.initialSettings_.serializedAppStateStr_ =
       '{"version":2,"recentDestinations":[{"id":"ID", "origin":"local",' +
         '"account":"", "capabilities":0, "name":"", "extensionId":"",' +
             '"extensionName":""}]}';
   this.setInitialSettings();
 
   testDone();
@@ skipping 160 matching lines @@
           ]
         }
       }
     }
   };
   this.setCapabilities(device);
 
   var otherOptions = $('other-options-settings');
   // If rasterization is an option, other options should be visible. If not,
   // there should be no available other options.
-  checkSectionVisible(otherOptions, !cr.isWindows && !cr.isMac);
-  if (!cr.isWindows && !cr.isMac) {
+  checkSectionVisible(otherOptions, isPrintAsImageEnabled());
+  if (isPrintAsImageEnabled()) {
     checkElementDisplayed(
         otherOptions.querySelector('#fit-to-page-container'), false);
     checkElementDisplayed(
         otherOptions.querySelector('#rasterize-container'), true);
   }
   checkSectionVisible($('media-size-settings'), false);
   checkSectionVisible($('scaling-settings'), false);
 
   testDone();
 });
 
 // When the source is 'HTML', we always hide the fit to page option and show
 // media size option.
 TEST_F('PrintPreviewWebUITest', 'SourceIsHTMLCapabilities', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var fitToPage = otherOptions.querySelector('#fit-to-page-container');
   var rasterize;
-  var rasterizeEnabled = !cr.isWindows && !cr.isMac;
-  if (rasterizeEnabled)
+  if (isPrintAsImageEnabled())
     rasterize = otherOptions.querySelector('#rasterize-container');
   var mediaSize = $('media-size-settings');
   var scalingSettings = $('scaling-settings');
 
   // Check that options are collapsed (section is visible, because duplex is
   // available).
   checkSectionVisible(otherOptions, true);
   checkElementDisplayed(fitToPage, false);
-  if (rasterizeEnabled)
+  if (isPrintAsImageEnabled())
     checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, false);
   checkSectionVisible(scalingSettings, false);
 
   this.expandMoreSettings();
 
   checkElementDisplayed(fitToPage, false);
-  if (rasterizeEnabled)
+  if (isPrintAsImageEnabled())
     checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, true);
   checkSectionVisible(scalingSettings, true);
 
   this.waitForAnimationToEnd('more-settings');
 });
 
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'SourceIsPDFCapabilities', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var scalingSettings = $('scaling-settings');
   var fitToPageContainer =
       otherOptions.querySelector('#fit-to-page-container');
-  var rasterizeEnabled = !cr.isWindows && !cr.isMac;
   var rasterizeContainer;
-  if (rasterizeEnabled) {
+  if (isPrintAsImageEnabled()) {
     rasterizeContainer =
       otherOptions.querySelector('#rasterize-container');
   }
 
   checkSectionVisible(otherOptions, true);
   checkElementDisplayed(fitToPageContainer, true);
-  if (rasterizeEnabled)
+  if (isPrintAsImageEnabled())
     checkElementDisplayed(rasterizeContainer, false);
   expectTrue(
       fitToPageContainer.querySelector('.checkbox').checked);
   this.expandMoreSettings();
-  if (rasterizeEnabled) {
+  if (isPrintAsImageEnabled()) {
     checkElementDisplayed(rasterizeContainer, true);
     expectFalse(
         rasterizeContainer.querySelector('.checkbox').checked);
   }
   checkSectionVisible($('media-size-settings'), true);
   checkSectionVisible(scalingSettings, true);
 
   this.waitForAnimationToEnd('other-options-collapsible');
 });
 
@@ skipping 667 matching lines @@
   // increments by 1 for each startGetPreview call it makes. It should only
   // make one such call during initialization or there will be a race; see
   // crbug.com/666595
   expectEquals(printPreview.previewArea_.previewGenerator_.inFlightRequestId_,
     -1);
   this.setInitialSettings();
   expectEquals(printPreview.previewArea_.previewGenerator_.inFlightRequestId_,
     0);
   testDone();
 });