ui/views/view.h - Issue 2718073003: Views a11y: Convert View's NativeViewAccessibility to a unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.h

Issue 2718073003: Views a11y: Convert View's NativeViewAccessibility to a unique_ptr. (Closed)

Patch Set: Fix long lived NVA in test. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/view.h

diff --git a/ui/views/view.h b/ui/views/view.h

index fcbee85c1bf2155eef7639c5b96e75c6980c1b4f..7e80124027bae66b775b5b68a3f9d4df96b9bd65 100644

--- a/ui/views/view.h

+++ b/ui/views/view.h

@@ -1616,9 +1616,8 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,

// Accessibility -------------------------------------------------------------

- // Belongs to this view, but it's reference-counted on some platforms

- // so we can't use a scoped_ptr. It's dereferenced in the destructor.

- NativeViewAccessibility* native_view_accessibility_;

+ // The accessibility element used to represent this View.

+ std::unique_ptr<NativeViewAccessibility> native_view_accessibility_;

// Observers -------------------------------------------------------------

« no previous file with comments | « ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »