Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ui/views/accessibility/native_view_accessibility_unittest.cc

Issue 2718073003: Views a11y: Convert View's NativeViewAccessibility to a unique_ptr. (Closed)
Patch Set: Fix long lived NVA in test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_unittest.cc b/ui/views/accessibility/native_view_accessibility_unittest.cc
index eecbff06989d23b22813e8b76bfd5eff8c9dd24e..74a84ffd4367f104c39b9acf7a0b6c62457dd346 100644
--- a/ui/views/accessibility/native_view_accessibility_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_unittest.cc
@@ -58,19 +58,15 @@ class NativeViewAccessibilityTest : public ViewsTestBase {
void TearDown() override {
if (!widget_->IsClosed())
widget_->Close();
- button_accessibility_->Destroy();
- button_accessibility_ = NULL;
- label_accessibility_->Destroy();
- label_accessibility_ = NULL;
ViewsTestBase::TearDown();
}
protected:
views::Widget* widget_;
TestButton* button_;
- NativeViewAccessibility* button_accessibility_;
+ std::unique_ptr<NativeViewAccessibility> button_accessibility_;
Label* label_;
- NativeViewAccessibility* label_accessibility_;
+ std::unique_ptr<NativeViewAccessibility> label_accessibility_;
};
TEST_F(NativeViewAccessibilityTest, RoleShouldMatch) {
« no previous file with comments | « ui/views/accessibility/native_view_accessibility_mac.mm ('k') | ui/views/accessibility/native_view_accessibility_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698