Views a11y: Convert View's NativeViewAccessibility to a unique_ptr.

ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/tabbed_pane/tabbed_pane.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 140 matching lines @@
 
   constexpr int kNumTabs = 3;
   for (int i = 0; i < kNumTabs; ++i) {
     tabbed_pane_->AddTab(DefaultTabTitle(), new View());
   }
   // Check the first tab is selected.
   EXPECT_EQ(0, tabbed_pane_->GetSelectedTabIndex());
 
   // Check the a11y information for each tab.
   for (int i = 0; i < kNumTabs; ++i) {
-    NativeViewAccessibility* nva = NativeViewAccessibility::Create(GetTabAt(i));
-    ui::AXNodeData data = nva->GetData();
+    ui::AXNodeData data =
+        NativeViewAccessibility::Create(GetTabAt(i))->GetData();
     SCOPED_TRACE(testing::Message() << "Tab at index: " << i);
     EXPECT_EQ(ui::AX_ROLE_TAB, data.role);
     EXPECT_EQ(DefaultTabTitle(), data.GetString16Attribute(ui::AX_ATTR_NAME));
     EXPECT_TRUE(data.HasStateFlag(ui::AX_STATE_SELECTABLE));
     EXPECT_EQ(i == 0, data.HasStateFlag(ui::AX_STATE_SELECTED));
-    nva->Destroy();
   }
 
   ui::AXActionData action;
   action.action = ui::AX_ACTION_SET_SELECTION;
   // Select the first tab.
-  NativeViewAccessibility* nva = NativeViewAccessibility::Create(GetTabAt(0));
-  nva->AccessibilityPerformAction(action);
+
+  NativeViewAccessibility::Create(GetTabAt(0))
+      ->AccessibilityPerformAction(action);
   EXPECT_EQ(0, tabbed_pane_->GetSelectedTabIndex());
-  nva->Destroy();
 
   // Select the second tab.
-  nva = NativeViewAccessibility::Create(GetTabAt(1));
+  std::unique_ptr<NativeViewAccessibility> nva =
+      NativeViewAccessibility::Create(GetTabAt(1));
   nva->AccessibilityPerformAction(action);
   EXPECT_EQ(1, tabbed_pane_->GetSelectedTabIndex());
   // Select the second tab again.
   nva->AccessibilityPerformAction(action);
   EXPECT_EQ(1, tabbed_pane_->GetSelectedTabIndex());
-  nva->Destroy();
 
   widget->CloseNow();

[sky, 2017/03/01 00:27:07]

nva outlives widget (and thus the tab). Is that ok?

[Patti Lor, 2017/03/01 07:13:13]

Ah, yeah I think it would be bad if someone tried to use |nva| after this line.
Fixed now, thanks!

 }
 
 }  // namespace test
 }  // namespace views