third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h - Issue 2718043003: Refactor InspectorCSSAgent to avoid an intermediate GlyphBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

Issue 2718043003: Refactor InspectorCSSAgent to avoid an intermediate GlyphBuffer (Closed)

Patch Set: review Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp ('K') | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

index 573e548f692bec3f06d0cc4f076fa6d35a648e63..dccaf6aa95f0e982cdd815489c0e0ead89d72b65 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

@@ -10,6 +10,7 @@

#include "wtf/Allocator.h"

#include "wtf/RefPtr.h"

#include "wtf/Vector.h"

+#include <tuple>

namespace blink {

@@ -57,6 +58,8 @@ class PLATFORM_EXPORT ShapeResultBuffer {

unsigned from,

unsigned to);

+ Vector<std::tuple<SimpleFontData*, size_t>> getRunFontData() const;

private:

static CharacterRange getCharacterRangeInternal(

const Vector<RefPtr<const ShapeResult>, 64>&,