Refactor InspectorCSSAgent to avoid an intermediate GlyphBuffer

third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h

 /*
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef CachingWordShaper_h
 #define CachingWordShaper_h
 
 #include "platform/geometry/FloatRect.h"
 #include "platform/text/TextRun.h"
 #include "wtf/Allocator.h"
 #include "wtf/PassRefPtr.h"
+#include "wtf/Vector.h"
+#include <tuple>
 
 namespace blink {
 
 struct CharacterRange;
 class Font;
 class GlyphBuffer;
+class ShapeCache;
 class SimpleFontData;
-class ShapeCache;
 struct GlyphData;
 
 class PLATFORM_EXPORT CachingWordShaper final {
   STACK_ALLOCATED();
   WTF_MAKE_NONCOPYABLE(CachingWordShaper);
 
  public:
-  CachingWordShaper(ShapeCache* cache) : m_shapeCache(cache) {}
+  explicit CachingWordShaper(const Font&);

[eae, 2017/02/27 23:24:59]

Now that all production code uses the new Font& constructor I'd prefer it if we
could update the tests to use that too. Otherwise the tests will test a
different code path and different assumptions than the production code.

[f(malita), 2017/02/28 03:27:47]

Done.

[eae, 2017/02/28 03:31:19]

Thank you!

+  CachingWordShaper(const Font& font, ShapeCache* shapeCache)
+      : m_font(font), m_shapeCache(shapeCache) {}
   ~CachingWordShaper() {}
 
-  float width(const Font*,
-              const TextRun&,
+  float width(const TextRun&,
               HashSet<const SimpleFontData*>* fallbackFonts,
               FloatRect* glyphBounds);
-  int offsetForPosition(const Font*,
-                        const TextRun&,
+  int offsetForPosition(const TextRun&,
                         float targetX,
                         bool includePartialGlyphs);
-  float fillGlyphBuffer(const Font*,
-                        const TextRun&,
-                        HashSet<const SimpleFontData*>*,
+  float fillGlyphBuffer(const TextRun&,
                         GlyphBuffer*,
                         unsigned from,
                         unsigned to);
-  float fillGlyphBufferForTextEmphasis(const Font*,
-                                       const TextRun&,
+  float fillGlyphBufferForTextEmphasis(const TextRun&,
                                        const GlyphData* emphasisData,
                                        GlyphBuffer*,
                                        unsigned from,
                                        unsigned to);
-  CharacterRange getCharacterRange(const Font*,
-                                   const TextRun&,
+  CharacterRange getCharacterRange(const TextRun&,
                                    unsigned from,
                                    unsigned to);
-  Vector<CharacterRange> individualCharacterRanges(const Font*, const TextRun&);
+  Vector<CharacterRange> individualCharacterRanges(const TextRun&);
+
+  Vector<std::tuple<SimpleFontData*, size_t>>

[eae, 2017/02/27 23:24:59]

Please use a struct instead of a tuple here, as is it is entirely unclear what
the size argument is for.

[f(malita), 2017/02/28 03:27:47]

Done.

+  getRunFontData(const TextRun&) const;

[eae, 2017/02/27 23:24:59]

nit: How about fontDataForRun(TextRun) or even just fontData(TextRun)?

[f(malita), 2017/02/28 03:27:47]

Done (fontData).

 
  private:
+  const Font& m_font;
   ShapeCache* m_shapeCache;
 };
 
 }  // namespace blink
 
 #endif  // CachingWordShaper_h