Remove RenderWidget::scheduleAnimation

Remove RenderWidget::scheduleAnimation

animation_update_pending_ is never reset to false, so this almost never does anything, and shouldn't matter with threaded compositor.

BUG=362164
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269472

[piman, 2014-05-08 01:16:56]

You may want to double-check layout tests, but otherwise LGTM.

[jbauman, 2014-05-08 05:47:49]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-05-08 05:48:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/271803004/1

[commit-bot: I haz the power, 2014-05-09 13:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 13:52:40]

Failed to apply patch for content/renderer/render_widget.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/render_widget.cc
  Hunk #1 FAILED at 384.
  Hunk #2 succeeded at 1134 (offset -1 lines).
  Hunk #3 succeeded at 1160 (offset -1 lines).
  Hunk #4 succeeded at 1187 (offset -1 lines).
  Hunk #5 succeeded at 1351 (offset -5 lines).
  1 out of 5 hunks FAILED -- saving rejects to file
content/renderer/render_widget.cc.rej

Patch:       content/renderer/render_widget.cc
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc
b/content/renderer/render_widget.cc
index
38dae3a51138205165ff259e8e1058fc122f24bd..1f02d25351965ba98727286c3ce16f38cae0f407
100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -384,7 +384,6 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type,
       suppress_next_char_events_(false),
       is_accelerated_compositing_active_(false),
       was_accelerated_compositing_ever_active_(false),
-      animation_update_pending_(false),
       invalidation_task_posted_(false),
       screen_info_(screen_info),
       device_scale_factor_(screen_info_.deviceScaleFactor),
@@ -1135,15 +1134,6 @@ void RenderWidget::ClearFocus() {
     webwidget_->setFocus(false);
 }
 
-void RenderWidget::AnimationCallback() {
-  TRACE_EVENT0("renderer", "RenderWidget::AnimationCallback");
-  if (!animation_update_pending_) {
-    TRACE_EVENT0("renderer", "EarlyOut_NoAnimationUpdatePending");
-    return;
-  }
-  FlushPendingInputEventAck();
-}
-
 void RenderWidget::InvalidationCallback() {
   TRACE_EVENT0("renderer", "RenderWidget::InvalidationCallback");
   invalidation_task_posted_ = false;
@@ -1170,13 +1160,6 @@ void RenderWidget::didInvalidateRect(const WebRect& rect)
{
   if (invalidation_task_posted_)
     return;
 
-  // When GPU rendering, combine pending animations and invalidations into
-  // a single update.
-  if (is_accelerated_compositing_active_ &&
-      animation_update_pending_ &&
-      animation_timer_.IsRunning())
-    return;
-
   // Perform updating asynchronously.  This serves two purposes:
   // 1) Ensures that we call WebView::Paint without a bunch of other junk
   //    on the call stack.
@@ -1204,13 +1187,6 @@ void RenderWidget::didScrollRect(int dx, int dy,
   if (invalidation_task_posted_)
     return;
 
-  // When GPU rendering, combine pending animations and invalidations into
-  // a single update.
-  if (is_accelerated_compositing_active_ &&
-      animation_update_pending_ &&
-      animation_timer_.IsRunning())
-    return;
-
   // Perform updating asynchronously.  This serves two purposes:
   // 1) Ensures that we call WebView::Paint without a bunch of other junk
   //    on the call stack.
@@ -1379,18 +1355,6 @@ void RenderWidget::scheduleComposite() {
   }
 }
 
-void RenderWidget::scheduleAnimation() {
-  if (animation_update_pending_)
-    return;
-
-  TRACE_EVENT0("gpu", "RenderWidget::scheduleAnimation");
-  animation_update_pending_ = true;
-  if (!animation_timer_.IsRunning()) {
-    animation_timer_.Start(FROM_HERE, base::TimeDelta::FromSeconds(0), this,
-                           &RenderWidget::AnimationCallback);
-  }
-}
-
 void RenderWidget::didChangeCursor(const WebCursorInfo& cursor_info) {
   // TODO(darin): Eliminate this temporary.
   WebCursor cursor;

[jbauman, 2014-05-09 21:05:25]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:08:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/271803004/20001

[commit-bot: I haz the power, 2014-05-10 01:49:18]

Change committed as 269472