Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: Source/core/rendering/RenderView.cpp

Issue 271803002: [RAL] Fix nested non-composited RenderView repainting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar rebaselines Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderView.cpp
diff --git a/Source/core/rendering/RenderView.cpp b/Source/core/rendering/RenderView.cpp
index e03ec3d79228cc71ba969447be9e8a7df78cbb1b..6eb8e8effbb9f9df4a71918d4b245a05304e9916 100644
--- a/Source/core/rendering/RenderView.cpp
+++ b/Source/core/rendering/RenderView.cpp
@@ -445,6 +445,19 @@ void RenderView::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint&)
}
}
+void RenderView::invalidateTreeAfterLayout(const RenderLayerModelObject& paintInvalidationContainer)
+{
+ ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
+ ASSERT(!needsLayout());
+
+ // We specifically need to repaint the viewRect since other renderers
+ // short-circuit on full-repaint.
+ if (doingFullRepaint() && !viewRect().isEmpty())
+ repaintViewRectangle(viewRect());
+
+ RenderBlock::invalidateTreeAfterLayout(paintInvalidationContainer);
+}
+
void RenderView::repaintViewRectangle(const LayoutRect& ur) const
{
ASSERT(!ur.isEmpty());
@@ -455,9 +468,12 @@ void RenderView::repaintViewRectangle(const LayoutRect& ur) const
// We always just invalidate the root view, since we could be an iframe that is clipped out
// or even invisible.
Element* elt = document().ownerElement();
- if (!elt)
- m_frameView->repaintContentRectangle(pixelSnappedIntRect(ur));
- else if (RenderBox* obj = elt->renderBox()) {
+ if (!elt) {
+ if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking)
+ layer()->repainter().setBackingNeedsRepaintInRect(ur);
+ else
+ m_frameView->repaintContentRectangle(pixelSnappedIntRect(ur));
+ } else if (RenderBox* obj = elt->renderBox()) {
LayoutRect vr = viewRect();
LayoutRect r = intersection(ur, vr);
« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698