[RAL] Fix nested non-composited RenderView repainting

Source/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 420 matching lines @@
             CompositeOperator previousOperator = paintInfo.context->compositeOperation();
             paintInfo.context->setCompositeOperation(CompositeCopy);
             paintInfo.context->fillRect(paintInfo.rect, baseColor);
             paintInfo.context->setCompositeOperation(previousOperator);
         } else {
             paintInfo.context->clearRect(paintInfo.rect);
         }
     }
 }
 
+void RenderView::repaintTreeAfterLayout(const RenderLayerModelObject& repaintContainer)

[Julien - ping for review, 2014/05/30 02:39:32]

This code path seems very artificial to me as I would expect the FrameView to
handle the full repaint case as it used to do before repaint-after-layout (see
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

[leviw_travelin_and_unemployed, 2014/05/30 15:52:57]

I'm not sure I understand what the "artificial" part of this comment really
means.

[dsinclair, 2014/06/02 00:38:29]

That code path is never hit in RAL. I don't necessarily think it should be. I
think it makes sense for all of the invalidating to happen the same way, if
possible, which means the RenderObjects doing the invalidation.

[Julien - ping for review, 2014/06/02 23:21:19]

It's not hit by RAL because we made it so, not because we can't have RAL hit it.
That was the fix I had in mind for this change but Levi pointed out it was
busted but hidden by our massive overinvalidation.

+{
+    ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
+    ASSERT(!needsLayout());
+
+    // We specifically need to repaint the viewRect since other renderers
+    // short-circuit on full-repaint.
+    if (doingFullRepaint() && !viewRect().isEmpty())
+        repaintViewRectangle(viewRect());
+
+    RenderBlock::repaintTreeAfterLayout(repaintContainer);
+}
+
 void RenderView::repaintViewRectangle(const LayoutRect& ur) const
 {
     ASSERT(!ur.isEmpty());
 
     if (document().printing() || !m_frameView)
         return;
 
     // We always just invalidate the root view, since we could be an iframe that is clipped out
     // or even invisible.
     Element* elt = document().ownerElement();
-    if (!elt)
-        m_frameView->repaintContentRectangle(pixelSnappedIntRect(ur));
-    else if (RenderBox* obj = elt->renderBox()) {
+    if (!elt) {
+        if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking)
+            layer()->repainter().setBackingNeedsRepaintInRect(ur);
+        else
+            m_frameView->repaintContentRectangle(pixelSnappedIntRect(ur));
+    } else if (RenderBox* obj = elt->renderBox()) {
         LayoutRect vr = viewRect();
         LayoutRect r = intersection(ur, vr);
 
         // Subtract out the contentsX and contentsY offsets to get our coords within the viewing
         // rectangle.
         r.moveBy(-vr.location());
 
         // FIXME: Hardcoded offsets here are not good.
         r.moveBy(obj->contentBoxRect().location());
         obj->repaintRectangle(r);
@@ skipping 529 matching lines @@
     return viewWidth(IncludeScrollbars) / scale;
 }
 
 double RenderView::layoutViewportHeight() const
 {
     float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1;
     return viewHeight(IncludeScrollbars) / scale;
 }
 
 } // namespace WebCore