Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 271803002: [RAL] Fix nested non-composited RenderView repainting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar rebaselines Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1579 matching lines...) Expand 10 before | Expand all | Expand 10 after
1590 // ASSERT(&newPaintInvalidationContainer == containerForRepaint()); 1590 // ASSERT(&newPaintInvalidationContainer == containerForRepaint());
1591 1591
1592 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect(); 1592 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect();
1593 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer(); 1593 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer();
1594 setPreviousPaintInvalidationRect(boundsRectForRepaint(&newPaintInvalidationC ontainer)); 1594 setPreviousPaintInvalidationRect(boundsRectForRepaint(&newPaintInvalidationC ontainer));
1595 setPreviousPositionFromPaintInvalidationContainer(positionFromRepaintContain er(&newPaintInvalidationContainer)); 1595 setPreviousPositionFromPaintInvalidationContainer(positionFromRepaintContain er(&newPaintInvalidationContainer));
1596 1596
1597 // If we are set to do a full paint invalidation that means the RenderView w ill be 1597 // If we are set to do a full paint invalidation that means the RenderView w ill be
1598 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child 1598 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child
1599 // renderers as they'll be covered by the RenderView. 1599 // renderers as they'll be covered by the RenderView.
1600 if (view()->doingFullRepaint() && this != view()) { 1600 if (view()->doingFullRepaint()) {
1601 LayoutStateMaintainer statePusher(*this, isTableRow() ? LayoutSize() : l ocationOffset()); 1601 LayoutStateMaintainer statePusher(*this, isTableRow() ? LayoutSize() : l ocationOffset());
1602 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer); 1602 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer);
1603 return; 1603 return;
1604 } 1604 }
1605 1605
1606 if ((onlyNeededPositionedMovementLayout() && compositingState() != PaintsInt oOwnBacking) 1606 if ((onlyNeededPositionedMovementLayout() && compositingState() != PaintsInt oOwnBacking)
1607 || (shouldDoFullPaintInvalidationIfSelfPaintingLayer() 1607 || (shouldDoFullPaintInvalidationIfSelfPaintingLayer()
1608 && hasLayer() 1608 && hasLayer()
1609 && layer()->isSelfPaintingLayer())) { 1609 && layer()->isSelfPaintingLayer())) {
1610 setShouldDoFullPaintInvalidationAfterLayout(true); 1610 setShouldDoFullPaintInvalidationAfterLayout(true);
(...skipping 3084 matching lines...) Expand 10 before | Expand all | Expand 10 after
4695 return 0; 4695 return 0;
4696 4696
4697 if (!layoutState && !flowThreadContainingBlock()) 4697 if (!layoutState && !flowThreadContainingBlock())
4698 return 0; 4698 return 0;
4699 4699
4700 RenderBlock* containerBlock = containingBlock(); 4700 RenderBlock* containerBlock = containingBlock();
4701 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop(); 4701 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
4702 } 4702 }
4703 4703
4704 } // namespace WebCore 4704 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/repaint/scrolled-iframe-scrollbar-change-expected.txt ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698