Support RGB32F and RGBA32F for CopyTextureCHROMIUM in ES2 with related extensions

gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GL_GLEXT_PROTOTYPES
 #define GL_GLEXT_PROTOTYPES
 #endif
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 755 matching lines @@
       }
 
       EXPECT_TRUE(GL_NO_ERROR == glGetError()) << "src_index:" << src_index
                                                << " dest_index:" << dest_index;
       glDeleteTextures(2, textures_);
       glDeleteFramebuffers(1, &framebuffer_id_);
     }
   }
 }
 
+TEST_P(GLCopyTextureCHROMIUMTest, InternalFormatRGBFloat) {
+  if (!GLTestHelper::HasExtension("GL_CHROMIUM_color_buffer_float_rgb")) {
+    LOG(INFO)
+        << "GL_CHROMIUM_color_buffer_float_rgb not supported. Skipping test...";
+    return;
+  }
+  // TODO(qiankun.miao@intel.com): since RunCopyTexture requires dest texture to
+  // be texture complete, skip this test if float texture is not color
+  // filterable. We should remove this limitation when we find a way doesn't
+  // require dest texture to be texture complete in RunCopyTexture.
+  if (!gl_.decoder()
+           ->GetFeatureInfo()
+           ->feature_flags()
+           .enable_texture_float_linear)

[Zhenyao Mo, 2017/03/02 17:31:53]

This is always false by default unless you explicitly enable it, so in that
sense, it seems to me that you are skipping these two tests everywhere, not just
where the extension is missing.

[Ken Russell (switch to Gerrit), 2017/03/02 18:26:06]

Is that accurate? It looks like GLManager::InitializeWithCommandLine uses an
empty DisallowedFeatures, and that causes
FeatureInfo::InitializeFloatAndHalfFloatFeatures to automatically enable these
features.

Either way, Qiankun, please add some logging in this early-return case so it is
obvious from the logs what is going on. Thanks.

+    return;
+  CopyType copy_type = GetParam();
+  FormatType src_format_type = {GL_RGBA, GL_RGBA, GL_UNSIGNED_BYTE};
+  FormatType dest_format_type = {GL_RGB32F, GL_RGB, GL_FLOAT};
+
+  RunCopyTexture(GL_TEXTURE_2D, copy_type, src_format_type, 0, dest_format_type,
+                 0, false);
+}
+
+TEST_P(GLCopyTextureCHROMIUMTest, InternalFormatRGBAFloat) {
+  if (!GLTestHelper::HasExtension("GL_CHROMIUM_color_buffer_float_rgba")) {
+    LOG(INFO) << "GL_CHROMIUM_color_buffer_float_rgba not supported. Skipping "
+                 "test...";
+    return;
+  }
+  // TODO(qiankun.miao@intel.com): since RunCopyTexture requires dest texture to
+  // be texture complete, skip this test if float texture is not color
+  // filterable. We should remove this limitation when we find a way doesn't
+  // require dest texture to be texture complete in RunCopyTexture.
+  if (!gl_.decoder()
+           ->GetFeatureInfo()
+           ->feature_flags()
+           .enable_texture_float_linear)
+    return;
+  CopyType copy_type = GetParam();
+  FormatType src_format_type = {GL_RGBA, GL_RGBA, GL_UNSIGNED_BYTE};
+  FormatType dest_format_type = {GL_RGBA32F, GL_RGBA, GL_FLOAT};
+
+  RunCopyTexture(GL_TEXTURE_2D, copy_type, src_format_type, 0, dest_format_type,
+                 0, false);
+}
+
 TEST_P(GLCopyTextureCHROMIUMTest, InternalFormatNotSupported) {
   CopyType copy_type = GetParam();
   CreateAndBindDestinationTextureAndFBO(GL_TEXTURE_2D);
   glBindTexture(GL_TEXTURE_2D, textures_[0]);
   glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE,
                nullptr);
   EXPECT_TRUE(GL_NO_ERROR == glGetError());
 
   // Check unsupported format reports error.
   GLint unsupported_dest_formats[] = {GL_RED, GL_RG};
@@ skipping 800 matching lines @@
         }
       }
 
       glDeleteTextures(2, textures_);
       glDeleteFramebuffers(1, &framebuffer_id_);
     }
   }
 }
 
 }  // namespace gpu