content/renderer/render_view_impl.cc - Issue 2717943002: Fix cc/paint skia type mismatches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2717943002: Fix cc/paint skia type mismatches (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index d7236ccde67a75f57aca3fc1400de3f2c4701d71..85a9fa9165edb0e29a705f97cb1c2731c7a74ee8 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -2538,8 +2538,7 @@ bool RenderViewImpl::didTapMultipleTargets(

SkImageInfo info = SkImageInfo::MakeN32Premul(canvas_size.width(),

canvas_size.height());

bitmap.installPixels(info, shared_bitmap->pixels(), info.minRowBytes());

- SkCanvas sk_canvas(bitmap);

- cc::PaintCanvasPassThrough canvas(&sk_canvas);

+ cc::PaintCanvas canvas(bitmap);

// TODO(trchen): Cleanup the device scale factor mess.

// device scale will be applied in WebKit