Implement WebFrame::swap.

Implement WebFrame::swap.

This just updates a bunch of pointers so a WebRemoteFrame can replace a
WebLocalFrame node, or vise versa. This does not currently preserve the
JS global context, which will be addressed in future patches.

BUG=346764
R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173592

[dcheng, 2014-05-07 23:03:29]

No tests yet, unfortunately. This is something of a chicken-and-egg problem.
We're getting closer, but not quite there yet for frame mirroring with
remote/local frames, but we can't get there without more implementation. I just
eyeballed WebFrame's members and wrote looked necessary.

[eseidel, 2014-05-08 00:13:01]

lgtm

https://codereview.chromium.org/271793002/diff/1/Source/web/WebFrame.cpp
File Source/web/WebFrame.cpp (right):

https://codereview.chromium.org/271793002/diff/1/Source/web/WebFrame.cpp#newc...
Source/web/WebFrame.cpp:19: if (m_parent->m_firstChild == this)
I probably would have written a overrideIfSetTo(m_parent->m_firstChild, this,
newFrame) helper, but it also may not be worth the 5 saved lines either.

[dcheng, 2014-05-08 01:54:18]

https://codereview.chromium.org/271793002/diff/1/Source/web/WebFrame.cpp
File Source/web/WebFrame.cpp (right):

https://codereview.chromium.org/271793002/diff/1/Source/web/WebFrame.cpp#newc...
Source/web/WebFrame.cpp:19: if (m_parent->m_firstChild == this)
On 2014/05/08 00:13:01, eseidel wrote:
> I probably would have written a overrideIfSetTo(m_parent->m_firstChild, this,
> newFrame) helper, but it also may not be worth the 5 saved lines either.

Yeah I think it may not be worth it at the moment.

[dcheng, 2014-05-08 01:54:25]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-05-08 01:55:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/271793002/1

[dcheng, 2014-05-08 01:57:52]

The CQ bit was unchecked by dcheng@chromium.org

[eseidel, 2014-05-08 02:11:30]

I do these things i think because I'm terrified of making copy paste bugs.
:)

On Wednesday, May 7, 2014, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/dcheng@chromium.org/271793002/1
>
>
> https://codereview.chromium.org/271793002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dcheng, 2014-05-08 03:04:32]

Committed patchset #2 manually as r173592 (presubmit successful).