Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2717893002: Omnibox - Warm Up PSuggest on Focus (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 935e2b1aa6e7617b04ad5416c91dd032fedd7e90..0cd71dca9bc95fc319aa5f0d9f803e7e770a7163 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -37,6 +37,14 @@ namespace omnibox {
const base::Feature kNewOmniboxAnswerTypes{"NewOmniboxAnswerTypes",
base::FEATURE_DISABLED_BY_DEFAULT};
+// Feature to enable the search provider to send a request to the suggest
+// server on focus. This allows the suggest server to warm up, by, for
+// example, loading per-user models into memory. Having a per-user model
+// in memory allows the suggest server to respond more question with
Peter Kasting 2017/03/01 03:00:34 Nit: more question -> to more questions
Mark P 2017/03/01 20:02:32 Actually, I intended "quickly". Done.
+// personalized suggestions as the user types.
+const base::Feature kSearchProviderWarmUpOnFocus{
+ "OmniboxWarmUpSearchProviderOnFocus", base::FEATURE_DISABLED_BY_DEFAULT};
+
} // namespace omnibox
namespace {

Powered by Google App Engine
This is Rietveld 408576698