Omnibox - Warm Up PSuggest on Focus

components/omnibox/browser/search_provider.h

Index: components/omnibox/browser/search_provider.h
diff --git a/components/omnibox/browser/search_provider.h b/components/omnibox/browser/search_provider.h
index 330a9f3251f7d63a59d28cc61c0bb4774089539b..f59b9d4f655dee7c18183d07b41f50c560a020ad 100644
--- a/components/omnibox/browser/search_provider.h
+++ b/components/omnibox/browser/search_provider.h
@@ -97,6 +97,7 @@ class SearchProvider : public BaseSearchProvider,
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, AnswersCache);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, RemoveExtraAnswers);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DoesNotProvideOnFocus);
+  FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SendsWarmUpRequestOnFocus);
   FRIEND_TEST_ALL_PREFIXES(InstantExtendedPrefetchTest, ClearPrefetchedResults);
   FRIEND_TEST_ALL_PREFIXES(InstantExtendedPrefetchTest, SetPrefetchQuery);
 
@@ -195,6 +196,15 @@ class SearchProvider : public BaseSearchProvider,
   // if suggested relevances cause undesirable behavior. Updates |done_|.
   void UpdateMatches();
 
+  // Check constraints that may be violated by suggested relevances and revises/

[Peter Kasting, 2017/03/02 22:50:42]

Nit: Check -> Checks

[Mark P, 2017/03/03 22:12:24]

Done.

+  // rolls back the suggested relevance scores to make all constraints old.

[Peter Kasting, 2017/03/02 22:50:42]

Nit: old -> hold

[Mark P, 2017/03/03 22:12:24]

Done.

+  void EnforceConstraints();
+
+  // Record the top suggestion (if any) for future use.  SearchProvider tries

[Peter Kasting, 2017/03/02 22:50:42]

Nit: Record -> Records

[Mark P, 2017/03/03 22:12:24]

Done.

+  // to ensure that an inline autocomplete suggestion does not change
+  // asynchronously.
+  void RecordTopSuggestion();
+
   // Called when |timer_| expires.  Sends the suggest requests.
   // If |query_is_private|, the function doesn't send this query to the default
   // provider.
@@ -223,7 +233,9 @@ class SearchProvider : public BaseSearchProvider,
   bool IsQuerySuitableForSuggest(bool* query_is_private) const;
 
   // Returns true if sending the query to a suggest server may leak sensitive
-  // information (and hence the suggest request shouldn't be sent).
+  // information (and hence the suggest request shouldn't be sent).  In
+  // particular, if the input type might be a URL, we take extra care so that
+  // it isn't sent to the server.
   bool IsQueryPotentionallyPrivate() const;
 
   // Remove existing keyword results if the user is no longer in keyword mode,