Omnibox - Warm Up PSuggest on Focus

chrome/browser/autocomplete/search_provider_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/search_provider.h"
 
 #include <stddef.h>
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/scoped_feature_list.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 3486 matching lines @@
 }
 
 TEST_F(SearchProviderTest, DoesNotProvideOnFocus) {
   AutocompleteInput input(
       base::ASCIIToUTF16("f"), base::string16::npos, std::string(), GURL(),
       metrics::OmniboxEventProto::INVALID_SPEC, false, true, true, true, true,
       ChromeAutocompleteSchemeClassifier(&profile_));
   provider_->Start(input, false);
   EXPECT_TRUE(provider_->matches().empty());
 }
+
+TEST_F(SearchProviderTest, SendsWarmUpRequestOnFocus) {
+  AutocompleteInput input(
+      base::ASCIIToUTF16("f"), base::string16::npos, std::string(), GURL(),
+      metrics::OmniboxEventProto::INVALID_SPEC, false, true, true, true, true,
+      ChromeAutocompleteSchemeClassifier(&profile_));
+
+  // First, verify that without the warm-up feature enabled, the provider
+  // immediately terminates with no matches.
+  provider_->Start(input, false);
+  // RunUntilIdle so that SearchProvider has a chance to create the URLFetchers
+  // (if it wants to, which it shouldn't in this case).
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(provider_->done());
+  EXPECT_TRUE(provider_->matches().empty());
+
+  // Then, check the behavior with the warm-up feature enabled.
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitAndEnableFeature(omnibox::kSearchProviderWarmUpOnFocus);
+  provider_->Start(input, false);
+  // RunUntilIdle so that SearchProvider create the URLFetcher.
+  base::RunLoop().RunUntilIdle();
+  EXPECT_FALSE(provider_->done());
+  EXPECT_TRUE(provider_->matches().empty());
+  // Make sure the default providers suggest service was queried.

[Peter Kasting, 2017/03/01 03:00:34]

Nit: provider's

[Mark P, 2017/03/01 20:02:32]

Done.

+  net::TestURLFetcher* fetcher = test_factory_.GetFetcherByID(
+      SearchProvider::kDefaultProviderURLFetcherID);
+  EXPECT_TRUE(fetcher);
+  // Even if the fetcher returns results, we should still have no suggestions
+  // (though the provider should now we done).

[Peter Kasting, 2017/03/01 03:00:34]

Nit: we -> be

[Mark P, 2017/03/01 20:02:32]

Done.

+  fetcher->set_response_code(200);
+  fetcher->SetResponseString("[\"\",[\"a\", \"b\"],[],[],{}]");

[Peter Kasting, 2017/03/01 03:00:34]

Nit: Might be more readable with a raw string literal:

  fetcher->SetResponseString(R"(["",["a", "b"],[],[],{}])");

[Mark P, 2017/03/01 20:02:32]

Indeed, it is.  I didn't know those existed. :-)

+  fetcher->delegate()->OnURLFetchComplete(fetcher);
+  RunTillProviderDone();
+  EXPECT_TRUE(provider_->done());
+  EXPECT_TRUE(provider_->matches().empty());
+}