DevTools: iterate on object preview style

third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 668 matching lines @@
     var targetValue = this.property.name !== '__proto__' ? propertyValue : this.property.parentObject;
     ObjectUI.ObjectPropertyTreeElement._populate(
         this, propertyValue, skipProto, this._linkifier, undefined, undefined, undefined, targetValue);
   }
 
   /**
    * @override
    * @return {boolean}
    */
   ondblclick(event) {
-    var inEditableElement = event.target.isSelfOrDescendant(this.valueElement) ||
-        (this.expandedValueElement && event.target.isSelfOrDescendant(this.expandedValueElement));
+    var inEditableElement = event.target.isSelfOrDescendant(this.valueElement);
     if (!this.property.value.customPreview() && inEditableElement && (this.property.writable || this.property.setter))
       this._startEditing();
     return false;
   }
 
   /**
    * @override
    */
   onattach() {
     this.update();
     this._updateExpandable();
   }
 
-  /**
-   * @override
-   */
-  onexpand() {
-    this._showExpandedValueElement(true);
-  }
-
-  /**
-   * @override
-   */
-  oncollapse() {
-    this._showExpandedValueElement(false);
-  }
-
-  /**
-   * @param {boolean} value
-   */
-  _showExpandedValueElement(value) {
-    if (!this.expandedValueElement)
-      return;
-    if (value)
-      this.listItemElement.replaceChild(this.expandedValueElement, this.valueElement);
-    else
-      this.listItemElement.replaceChild(this.valueElement, this.expandedValueElement);
-  }
-
-  /**
-   * @param {!SDK.RemoteObject} value
-   * @return {?Element}
-   */
-  _createExpandedValueElement(value) {
-    var needsAlternateValue = value.hasChildren && !value.customPreview() && value.subtype !== 'node' &&
-        value.type !== 'function' && (value.type !== 'object' || value.preview);
-    if (!needsAlternateValue)
-      return null;
-
-    var valueElement = createElementWithClass('span', 'value');
-    valueElement.setTextContentTruncatedIfNeeded(value.description || '');
-    valueElement.classList.add('object-value-' + (value.subtype || value.type));
-    valueElement.title = value.description || '';
-    return valueElement;
-  }
-
   update() {
     this.nameElement = ObjectUI.ObjectPropertiesSection.createNameElement(this.property.name);
     if (!this.property.enumerable)
       this.nameElement.classList.add('object-properties-section-dimmed');
     if (this.property.synthetic)
       this.nameElement.classList.add('synthetic-property');
 
     this._updatePropertyPath();
     this.nameElement.addEventListener('contextmenu', this._contextMenuFired.bind(this, this.property), false);
 
     var separatorElement = createElementWithClass('span', 'object-properties-section-separator');
     separatorElement.textContent = ': ';
 
     if (this.property.value) {
       var showPreview = this.property.name !== '__proto__';
       this.valueElement = ObjectUI.ObjectPropertiesSection.createValueElementWithCustomSupport(
           this.property.value, this.property.wasThrown, showPreview, this.listItemElement, this._linkifier);
       this.valueElement.addEventListener('contextmenu', this._contextMenuFired.bind(this, this.property), false);
     } else if (this.property.getter) {
       this.valueElement = ObjectUI.ObjectPropertyTreeElement.createRemoteObjectAccessorPropertySpan(
           this.property.parentObject, [this.property.name], this._onInvokeGetterClick.bind(this));
     } else {
       this.valueElement = createElementWithClass('span', 'object-value-undefined');
       this.valueElement.textContent = Common.UIString('<unreadable>');
       this.valueElement.title = Common.UIString('No property getter');
     }
 
-    var valueText = this.valueElement.textContent;
-    if (this.property.value && valueText && !this.property.wasThrown)
-      this.expandedValueElement = this._createExpandedValueElement(this.property.value);
-
     this.listItemElement.removeChildren();
     this.listItemElement.appendChildren(this.nameElement, separatorElement, this.valueElement);
   }
 
   _updatePropertyPath() {
     if (this.nameElement.title)
       return;
 
     var useDotNotation = /^(_|\$|[A-Z])(_|\$|[A-Z]|\d)*$/i;
     var isInteger = /^[1-9]\d*$/;
@@ skipping 555 matching lines @@
     }
     var treeOutlineId = treeElement.treeOutline[ObjectUI.ObjectPropertiesSectionExpandController._treeOutlineId];
     result = treeOutlineId + (result ? ':' + result : '');
     treeElement[ObjectUI.ObjectPropertiesSectionExpandController._cachedPathSymbol] = result;
     return result;
   }
 };
 
 ObjectUI.ObjectPropertiesSectionExpandController._cachedPathSymbol = Symbol('cachedPath');
 ObjectUI.ObjectPropertiesSectionExpandController._treeOutlineId = Symbol('treeOutlineId');