DevTools: iterate on object preview style

third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 ObjectUI.RemoteObjectPreviewFormatter = class {
   /**
    * @param {!Protocol.Runtime.PropertyPreview} a
    * @param {!Protocol.Runtime.PropertyPreview} b
    * @return {number}
    */
   static _objectPropertyComparator(a, b) {
     if (a.type !== 'function' && b.type === 'function')
       return -1;
     if (a.type === 'function' && b.type !== 'function')
       return 1;
     return 0;
   }
 
   /**
    * @param {!Element} parentElement
    * @param {!Protocol.Runtime.ObjectPreview} preview
    * @param {boolean} isEntry
    */
   appendObjectPreview(parentElement, preview, isEntry) {
     const previewExperimentEnabled = Runtime.experiments.isEnabled('objectPreviews');
     var description = preview.description;
-    if (preview.type !== 'object' || preview.subtype === 'null' || (previewExperimentEnabled && isEntry)) {
+    var subTypesWithoutValuePreview = new Set(['null', 'regexp', 'error', 'internal#entry']);
+    if (preview.type !== 'object' || subTypesWithoutValuePreview.has(preview.subtype) ||
+        (previewExperimentEnabled && isEntry)) {
       parentElement.appendChild(this.renderPropertyPreview(preview.type, preview.subtype, description));
       return;
     }
     const isArrayOrTypedArray = preview.subtype === 'array' || preview.subtype === 'typedarray';
     if (description) {
       var text;
       if (isArrayOrTypedArray) {
         var arrayLength = SDK.RemoteObject.arrayLength(preview);
         var arrayLengthText = arrayLength > 1 ? ('(' + arrayLength + ')') : '';
         var arrayName = preview.subtype === 'typedarray' ? SDK.RemoteObject.arrayNameFromDescription(description) : '';
         text = arrayName + arrayLengthText;
       } else {
         var hideDescription = previewExperimentEnabled && description === 'Object';
         text = hideDescription ? '' : description;
       }
       if (text.length > 0)
         parentElement.createChild('span', 'object-description').textContent = text + ' ';
     }
 
     var propertiesElement = parentElement.createChild('span', 'object-properties-preview source-code');
     propertiesElement.createTextChild(isArrayOrTypedArray ? '[' : '{');
     if (preview.entries)
       this._appendEntriesPreview(propertiesElement, preview);
     else if (isArrayOrTypedArray)
       this._appendArrayPropertiesPreview(propertiesElement, preview);
     else
       this._appendObjectPropertiesPreview(propertiesElement, preview);
-    if (preview.overflow)
-      propertiesElement.createChild('span').textContent = '\u2026';
+    if (preview.overflow) {
+      var ellipsisText = propertiesElement.textContent.length > 1 ? ',\u00a0\u2026' : '\u2026';
+      propertiesElement.createChild('span').textContent = ellipsisText;
+    }
     propertiesElement.createTextChild(isArrayOrTypedArray ? ']' : '}');
   }
 
   /**
    * @param {string} description
    * @return {string}
    */
   _abbreviateFullQualifiedClassName(description) {
     var abbreviatedDescription = description.split('.');
     for (var i = 0; i < abbreviatedDescription.length - 1; ++i)
@@ skipping 174 matching lines @@
         preview = '{\u2026}';
       span.textContent = preview;
       span.title = description;
       return span;
     }
 
     span.textContent = description;
     return span;
   }
 };