Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 27178002: Reduce queue size in dead code elimination by eagerly processing live instructions. (Closed)

Created:
7 years, 2 months ago by titzer
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reduce queue size in dead code elimination by eagerly processing live instructions. BUG= R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17196

Patch Set 1 #

Total comments: 1

Patch Set 2 : Assert the worklist is empty at the end of processing live instructions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M src/hydrogen-dce.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-dce.cc View 1 1 chunk +35 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
Measured an 7x decrease in the memory allocated in the zone during this phase, from ...
7 years, 2 months ago (2013-10-14 12:18:53 UTC) #1
titzer
7 years, 2 months ago (2013-10-14 12:20:49 UTC) #2
rmcilroy
lgtm with one nit. Nice, thanks! https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc File src/hydrogen-dce.cc (right): https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc#newcode35 src/hydrogen-dce.cc:35: HValue* instr, ZoneList<HValue*>* ...
7 years, 2 months ago (2013-10-14 12:43:29 UTC) #3
titzer
On 2013/10/14 12:43:29, rmcilroy wrote: > lgtm with one nit. > > Nice, thanks! > ...
7 years, 2 months ago (2013-10-14 13:19:01 UTC) #4
titzer
7 years, 2 months ago (2013-10-14 13:32:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17196 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698