Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2717723002: Convert Audio/cycle-connection-gc test to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioNode/cycle-connection-gc test to testharness Manually convert test to use testharness and new Audit. BUG=682011 TEST=cycle-connection-gc.html

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioNode/cycle-connection-gc.html View 1 chunk +38 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioNode/cycle-connection-gc-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-24 22:02:53 UTC) #3
hongchan
lgtm
3 years, 9 months ago (2017-02-27 18:06:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717723002/1
3 years, 9 months ago (2017-02-27 18:11:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/390481)
3 years, 9 months ago (2017-02-27 20:46:40 UTC) #8
Raymond Toy
3 years, 9 months ago (2017-03-01 22:15:17 UTC) #9
Let's not convert this to testharness. I don't understand why this fails on
windows but not other bots.

Powered by Google App Engine
This is Rietveld 408576698