Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2717673002: Use printUnexpected and add location information. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/errors.dart ('k') | pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 67c49ed80e6aade3564a4c70a18b69aeca7a6db9..dd46228973611181190f0c4bee29ef84f52c64bd 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -37,7 +37,6 @@ import 'package:front_end/src/fasta/scanner/token.dart' show
isMinusOperator;
import '../errors.dart' show
- InputError,
internalError,
printUnexpected;
@@ -1577,13 +1576,13 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
@override
Expression buildStaticInvocation(Member target, Arguments arguments,
- {bool isConst: false}) {
+ {bool isConst: false, int charOffset: -1}) {
List<TypeParameter> typeParameters = target.function.typeParameters;
if (target is Constructor) {
typeParameters = target.enclosingClass.typeParameters;
}
if (!addDefaultArguments(target.function, arguments, typeParameters)) {
- return throwNoSuchMethodError(target.name.name, arguments, -1);
+ return throwNoSuchMethodError(target.name.name, arguments, charOffset);
}
if (target is Constructor) {
return new ConstructorInvocation(target, arguments)
@@ -1694,7 +1693,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
if (target is Constructor ||
(target is Procedure && target.kind == ProcedureKind.Factory)) {
push(buildStaticInvocation(
- target, arguments, isConst: optional("const", token)));
+ target, arguments, isConst: optional("const", token),
+ charOffset: token.charOffset));
return;
} else {
errorName = debugName(type.name, name);
@@ -2195,8 +2195,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
void handleRecoverableError(Token token, ErrorKind kind, Map arguments) {
super.handleRecoverableError(token, kind, arguments);
if (!hasParserError) {
- print(new InputError(uri, recoverableErrors.last.beginOffset,
- recoverableErrors.last.kind).format());
+ printUnexpected(uri, recoverableErrors.last.beginOffset,
+ '${recoverableErrors.last.kind}');
}
hasParserError = true;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/errors.dart ('k') | pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698