Clean up SyncCompositorFactory context creation

Clean up SyncCompositorFactory context creation

Separate out context creation that does not need surface or service
into separate CreateOffscreenContext call.

Do not create GLSurfaceStubs on client side, and pass in NULL window
so the context creates GLSurfaceStubs on service side.

Clean up share context code since compositor does not need an offscreen
context anymore.

BUG=370566
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269618

[no sievers, 2014-05-08 18:57:14]

Let's not do the gpu/ changes as it makes the code worse. If the refcounting is
not thread-safe we should not pass the object around threads. Somebody will just
go in and create a totally unexpected regression/bug later (by doing the right
thing or making the code better).

In fact, why is it even needed? The new shared offscreen context and video
context are created with a GLSurfaceStub. The service will already create a
GLSurfaceStub if the window handle is kNullAcceleratedWidget (see
gl_surface_android.cc).

https://codereview.chromium.org/271763002/diff/1/content/browser/android/in_p...
File content/browser/android/in_process/synchronous_compositor_impl.cc (right):

https://codereview.chromium.org/271763002/diff/1/content/browser/android/in_p...
content/browser/android/in_process/synchronous_compositor_impl.cc:97: // along
correctly.
If you are removing this, then the comment does not apply anymore and you should
remove it too.

[boliu, 2014-05-08 21:57:46]

PTAL

[no sievers, 2014-05-09 17:47:06]

lgtm

https://codereview.chromium.org/271763002/diff/60001/content/browser/android/...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/271763002/diff/60001/content/browser/android/...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:179:
void SynchronousCompositorFactoryImpl::EnsureShareContextCreated() {
Maybe just inline this below since it may only happen in one place, or at least
from one thread anyway?

[boliu, 2014-05-09 17:59:20]

https://codereview.chromium.org/271763002/diff/60001/content/browser/android/...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/271763002/diff/60001/content/browser/android/...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:179:
void SynchronousCompositorFactoryImpl::EnsureShareContextCreated() {
On 2014/05/09 17:47:06, sievers wrote:
> Maybe just inline this below since it may only happen in one place, or at
least
> from one thread anyway?

There is only one caller. Inlined.

[boliu, 2014-05-09 17:59:43]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-05-09 18:00:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/271763002/80001

[commit-bot: I haz the power, 2014-05-10 19:20:07]

Change committed as 269618