Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 2717613003: Views Page Info: Implement expanding all permissions (Closed)
Patch Set: Views Page Info: Implement expanding all permissions Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
index b1e64390e565633641b6523d47b096722a445825..ce74ba2c41253e9e09ec7d5b44cf7bcabef4de83 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
@@ -139,6 +139,10 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,
// returned view is transferred to the caller.
views::View* CreateSiteSettingsView(int side_margin) WARN_UNUSED_RESULT;
+ // Creates the contents of the |site_settings_view_|. The ownership of the
msw 2017/02/24 18:42:49 This comment is copy-pasted from above, please upd
lgarron 2017/02/28 03:21:01 Done.
+ // returned view is transferred to the caller.
+ views::Link* CreatePermissionLink() WARN_UNUSED_RESULT;
+
// Used to asynchronously handle clicks since these calls may cause the
// destruction of the settings view and the base class window still needs to
// be alive to finish handling the mouse or keyboard click.
@@ -170,6 +174,10 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,
views::Link* cookie_dialog_link_;
// The view that contains the "Permissions" table of the site settings view.
views::View* permissions_view_;
+ // The link that either:
+ // - expands the bubble to show all permissions, or
+ // - opens site settings in chrome://settings
+ views::Link* permission_link_;
// The certificate provided by the site, if one exists.
scoped_refptr<net::X509Certificate> certificate_;

Powered by Google App Engine
This is Rietveld 408576698