chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Now with proper enum formatting Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

index f8baba4528cf72d3d48bcbb1870bca2ef00d6f01..f7e8f1ee5a946911bf429f9a0128f12b71888193 100644

--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

@@ -246,7 +246,8 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {

}

- (info_bubble::BubbleArrowLocation)getExpectedArrowLocation {

- return [self hasLocationBar] ? info_bubble::kTopLeft : info_bubble::kNoArrow;

+ return [self hasLocationBar] ? info_bubble::kTopLeading

+ : info_bubble::kNoArrow;

}

- (NSWindow*)getExpectedParentWindow {