chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Now with proper enum formatting Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

index 54fa903eec0f8406e436a1f3f197f5cb5d8c6275..68c237a8829e056582b482dcd87a93bcf0c87844 100644

--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

@@ -118,7 +118,7 @@

browserWindowControllerForWindow:[self parentWindow]];

anchorPoint = [controller locationBarBridge]->GetBubblePointForDecoration(

[self decorationForBubble]);

- arrow = info_bubble::kTopRight;

+ arrow = info_bubble::kTopTrailing;

} else {

// Center the bubble if there's no location bar.

NSRect contentFrame = [[[self parentWindow] contentView] frame];