chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Now with proper enum formatting Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index deed5a8c0b80d661c818e8284b0235366dd7f980..a4d6598648122cd3103e42e14d68d8f07e844fce 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -285,9 +285,9 @@ std::unique_ptr<BubbleUi> ExtensionInstalledBubble::BuildBubbleUi() {

if (installedBubble_ &&

installedBubble_->anchor_position() ==

ExtensionInstalledBubble::ANCHOR_OMNIBOX) {

- [self.bubble setArrowLocation:info_bubble::kTopLeft];

+ [self.bubble setArrowLocation:info_bubble::kTopLeading];

} else {

- [self.bubble setArrowLocation:info_bubble::kTopRight];

+ [self.bubble setArrowLocation:info_bubble::kTopTrailing];

}

// Set appropriate icon, resizing if necessary.