chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

index 63e41ba3b8125972997bbff4e3685b332e99c6b6..2fc70ee804b0f98bbd54f47a1012816a3b444c27 100644

--- a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

@@ -47,7 +47,7 @@ anchoredAt:(NSPoint)anchorPoint

if ((self = [super initWithWindow:window.get()

parentWindow:parentWindow

anchoredAt:anchorPoint])) {

- [[self bubble] setArrowLocation:info_bubble::kTopLeft];

+ [[self bubble] setArrowLocation:info_bubble::kTopLeading];

self.shouldOpenAsKeyWindow = NO;

NSView* contentView = [ValidationMessageBubbleController