chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm » ('j') | chrome/browser/ui/cocoa/info_bubble_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

index 4716672725e0f2aa563dc0495fa4e4c2409f1e65..e8d55a729b4a53b632c4b426f33db95bba9d753e 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

@@ -791,7 +791,7 @@ const ContentTypeToNibPath kNibPaths[] = {

ContentSettingSimpleBubbleModel* simple_bubble =

contentSettingBubbleModel_->AsSimpleBubbleModel();

- [[self bubble] setArrowLocation:info_bubble::kTopRight];

+ [[self bubble] setArrowLocation:info_bubble::kTopTrailing];

// Adapt window size to bottom buttons. Do this before all other layouting.

if (simple_bubble && !simple_bubble->bubble_content().manage_text.empty())