[Mac] Make bubble arrow location/position RTL-aware

chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #import "base/mac/scoped_nsobject.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
@@ skipping 147 matching lines @@
   base::scoped_nsobject<InfoBubbleWindow> bubble_window_;
   BaseBubbleController* controller_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BaseBubbleControllerTest);
 };
 
 // Test that kAlignEdgeToAnchorEdge and a left bubble arrow correctly aligns the
 // left edge of the buble to the anchor point.
 TEST_F(BaseBubbleControllerTest, LeftAlign) {
-  [[controller_ bubble] setArrowLocation:info_bubble::kTopLeft];
+  [[controller_ bubble] setArrowLocation:info_bubble::kTopLeading];
   [[controller_ bubble] setAlignment:info_bubble::kAlignEdgeToAnchorEdge];
   [controller_ showWindow:nil];
 
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble is left aligned.
   EXPECT_EQ(NSMinX(frame), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
 // Test that kAlignEdgeToAnchorEdge and a right bubble arrow correctly aligns
 // the right edge of the buble to the anchor point.
 TEST_F(BaseBubbleControllerTest, RightAlign) {
-  [[controller_ bubble] setArrowLocation:info_bubble::kTopRight];
+  [[controller_ bubble] setArrowLocation:info_bubble::kTopTrailing];
   [[controller_ bubble] setAlignment:info_bubble::kAlignEdgeToAnchorEdge];
   [controller_ showWindow:nil];
 
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble is left aligned.
   EXPECT_EQ(NSMaxX(frame), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
 // Test that kAlignArrowToAnchor and a left bubble arrow correctly aligns
 // the bubble arrow to the anchor point.
 TEST_F(BaseBubbleControllerTest, AnchorAlignLeftArrow) {
-  [[controller_ bubble] setArrowLocation:info_bubble::kTopLeft];
+  [[controller_ bubble] setArrowLocation:info_bubble::kTopLeading];
   [[controller_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];
   [controller_ showWindow:nil];
 
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble arrow points to the anchor.
   EXPECT_EQ(NSMinX(frame) + info_bubble::kBubbleArrowXOffset +
       roundf(info_bubble::kBubbleArrowWidth / 2.0), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
 // Test that kAlignArrowToAnchor and a right bubble arrow correctly aligns
 // the bubble arrow to the anchor point.
 TEST_F(BaseBubbleControllerTest, AnchorAlignRightArrow) {
-  [[controller_ bubble] setArrowLocation:info_bubble::kTopRight];
+  [[controller_ bubble] setArrowLocation:info_bubble::kTopTrailing];
   [[controller_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];
   [controller_ showWindow:nil];
 
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble arrow points to the anchor.
   EXPECT_EQ(NSMaxX(frame) - info_bubble::kBubbleArrowXOffset -
       floorf(info_bubble::kBubbleArrowWidth / 2.0), kAnchorPointX);
@@ skipping 13 matching lines @@
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble arrow points to the anchor.
   EXPECT_EQ(NSMidX(frame), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
 // Test that the window is given an initial position before being shown. This
 // ensures offscreen initialization is done using correct screen metrics.
 TEST_F(BaseBubbleControllerTest, PositionedBeforeShow) {
   // Verify default alignment settings, used when initialized in SetUp().
-  EXPECT_EQ(info_bubble::kTopRight, [[controller_ bubble] arrowLocation]);
+  EXPECT_EQ(info_bubble::kTopTrailing, [[controller_ bubble] arrowLocation]);
   EXPECT_EQ(info_bubble::kAlignArrowToAnchor, [[controller_ bubble] alignment]);
 
   // Verify the default frame (positioned relative to the test_window() origin).
   NSRect frame = [[controller_ window] frame];
   EXPECT_EQ(NSMaxX(frame) - info_bubble::kBubbleArrowXOffset -
       floorf(info_bubble::kBubbleArrowWidth / 2.0), kAnchorPointX);
   EXPECT_EQ(NSMaxY(frame), kAnchorPointY);
 }
 
 // Tests that when a new window gets key state (and the bubble resigns) that
@@ skipping 181 matching lines @@
 
   // Post the "resign key" notification for another window.
   NSNotification* notif =
       [NSNotification notificationWithName:NSWindowDidResignKeyNotification
                                     object:test_window()];
   [[NSNotificationCenter defaultCenter] postNotification:notif];
 
   EXPECT_TRUE([bubble_window_ isVisible]);
   g_key_window = nil;
 }