[Mac] Make bubble arrow location/position RTL-aware

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 96 matching lines @@
 
   BrowserWindowController* bwc =
       [BrowserWindowController browserWindowControllerForWindow:parentWindow_];
   if (bwc) {
     TabStripController* tabStripController = [bwc tabStripController];
     TabStripModel* tabStripModel = [tabStripController tabStripModel];
     tabStripObserverBridge_.reset(new TabStripModelObserverBridge(tabStripModel,
                                                                   self));
   }
 
-  [bubble_ setArrowLocation:info_bubble::kTopRight];
+  [bubble_ setArrowLocation:info_bubble::kTopTrailing];
 }
 
 - (void)dealloc {
   [self unregisterFromNotifications];
   [super dealloc];
 }
 
 - (void)registerForNotifications {
   // No window to register notifications for.
   if (!parentWindow_)
@@ skipping 276 matching lines @@
   NSWindow* window = [self window];
   NSPoint origin = anchor_;
 
   BOOL isRTL = cocoa_l10n_util::ShouldDoExperimentalRTLLayout();
   switch ([bubble_ alignment]) {
     case info_bubble::kAlignArrowToAnchor: {
       NSSize offsets = NSMakeSize(info_bubble::kBubbleArrowXOffset +
                                   info_bubble::kBubbleArrowWidth / 2.0, 0);
       offsets = [[parentWindow_ contentView] convertSize:offsets toView:nil];
       switch ([bubble_ arrowLocation]) {
-        case info_bubble::kTopRight:
-          origin.x -= NSWidth([window frame]) - offsets.width;
+        case info_bubble::kTopTrailing:
+          origin.x -=
+              isRTL ? offsets.width : NSWidth([window frame]) - offsets.width;
           break;
-        case info_bubble::kTopLeft:
-          origin.x -= offsets.width;
+        case info_bubble::kTopLeading:
+          origin.x -=
+              isRTL ? NSWidth([window frame]) - offsets.width : offsets.width;
           break;
         case info_bubble::kNoArrow:
         // FALLTHROUGH.
         case info_bubble::kTopCenter:
           origin.x -= NSWidth([window frame]) / 2.0;
           break;
       }
       break;
     }
 
     case info_bubble::kAlignEdgeToAnchorEdge:
       // If the arrow is to the right then move the origin so that the right
       // edge aligns with the anchor. If the arrow is to the left then there's
       // nothing to do because the left edge is already aligned with the left
       // edge of the anchor.
-      if ([bubble_ arrowLocation] == info_bubble::kTopRight) {
+      if ([bubble_ arrowLocation] == info_bubble::kTopTrailing) {
         origin.x -= NSWidth([window frame]);
       }
       break;
 
     case info_bubble::kAlignTrailingEdgeToAnchorEdge:
       if (!isRTL)
         origin.x -= NSWidth([window frame]);
       break;
 
     case info_bubble::kAlignLeadingEdgeToAnchorEdge:
@@ skipping 11 matching lines @@
 
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason {
   // The user switched tabs; close.
   [self closeBubble];
 }
 
 @end  // BaseBubbleController