Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: cc/trees/draw_property_utils.cc

Issue 2717533005: cc: RenderSurfaceImpl tile mask layer. (Closed)
Patch Set: Addressing comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/draw_property_utils.cc
diff --git a/cc/trees/draw_property_utils.cc b/cc/trees/draw_property_utils.cc
index c5128934db98361f1c752b674aa0a11b06d49455..5d07b575d300d609b59f6bbb9d128a689203a542 100644
--- a/cc/trees/draw_property_utils.cc
+++ b/cc/trees/draw_property_utils.cc
@@ -1376,6 +1376,12 @@ void ComputeMaskDrawProperties(LayerImpl* mask_layer,
const PropertyTrees* property_trees) {
// Mask draw properties are used only for rastering, so most of the draw
// properties computed for other layers are not needed.
+ // Draw transform of a mask layer has to be a 2d scale.
+ // TODO(sunxd): the draw transform of a mask layer misses the "scale to fit"
+ // factor from mask layer to its parent. So does the screen space transform.
+ // It does not cause a problem because currently we only have 1:1 mask layer.
+ mask_layer->draw_properties().target_space_transform = DrawTransform(
+ mask_layer, property_trees->transform_tree, property_trees->effect_tree);
mask_layer->draw_properties().screen_space_transform =
ScreenSpaceTransformInternal(mask_layer,
property_trees->transform_tree);

Powered by Google App Engine
This is Rietveld 408576698