Fix crash in ReparentItemToAnotherFolder() on Windows app list.

Fix crash in ReparentItemToAnotherFolder() on Windows app list.

This CL fixes a crash in the app list where a NULL AppListItemView
wasn't checked.

BUG=371309
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269524

[tapted, 2014-05-09 02:55:46]

https://codereview.chromium.org/271753007/diff/1/ui/app_list/views/apps_grid_...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/271753007/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view.cc:1686: return;
I think this will ~leak the observer removed up on line 1675 - should be OK just
to move this up to the top of the function though.

[calamity, 2014-05-09 03:13:02]

https://codereview.chromium.org/271753007/diff/1/ui/app_list/views/apps_grid_...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/271753007/diff/1/ui/app_list/views/apps_grid_...
ui/app_list/views/apps_grid_view.cc:1686: return;
On 2014/05/09 02:55:47, tapted wrote:
> I think this will ~leak the observer removed up on line 1675 - should be OK
just
> to move this up to the top of the function though.

Done.

[tapted, 2014-05-09 03:18:01]

lgtm

[calamity, 2014-05-09 04:12:12]

The CQ bit was checked by calamity@chromium.org

[calamity, 2014-05-09 04:12:12]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2014-05-09 04:12:18]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-09 04:35:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/271753007/20001

[commit-bot: I haz the power, 2014-05-09 10:40:38]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 14:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 14:15:46]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tapted, 2014-05-09 14:56:06]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-05-09 15:00:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/271753007/20001

[commit-bot: I haz the power, 2014-05-10 04:40:47]

Change committed as 269524